Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL field on HTTPRequestLog should have max length of 2048 #3337

Merged
merged 1 commit into from
Jun 4, 2021

Conversation

nicpottier
Copy link
Collaborator

Blowing up when calling Classifiers like Wit which use GET attributes on their URL

@codecov
Copy link

codecov bot commented Jun 4, 2021

Codecov Report

Merging #3337 (e640189) into main (0a94ef6) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #3337   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          367       368    +1     
  Lines        24592     24596    +4     
=========================================
+ Hits         24592     24596    +4     
Impacted Files Coverage Δ
...a/request_logs/migrations/0009_resize_url_field.py 100.00% <100.00%> (ø)
temba/request_logs/models.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a94ef6...e640189. Read the comment docs.

@rowanseymour rowanseymour merged commit 068c913 into main Jun 4, 2021
@rowanseymour rowanseymour deleted the long-urls branch June 4, 2021 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants