Add fetch templates for Twilio WhatsApp and transform the Twilio cont… #5148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5148 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 462 460 -2
Lines 24931 24985 +54
=========================================
+ Hits 24931 24985 +54 ☔ View full report in Codecov by Sentry. |
norkans7
force-pushed
the
twilio-content-templates
branch
3 times, most recently
from
1cb105e
to
44b6dfa
Compare
norkans7
commented
Apr 5, 2024
| components.append({"type": "body", "text": temp["types"][content_type]["body"]}) | ||
| if "media" in temp["types"][content_type]: | ||
| if extract_params(temp["types"][content_type]["media"][0]): | ||
| components.append({"type": "header", "format": "unknown"}) |
There was a problem hiding this comment.
we use format unknown, since we cannot figure out the exact attachment type
There was a problem hiding this comment.
And we do not support attachments yet
…ent to WA style templates
norkans7
force-pushed
the
twilio-content-templates
branch
from
44b6dfa
to
ef24d16
Compare
|
Replaced by #5183 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ent to WA style templates
I need to first figure out how the contentVariables will be handled to be passed to the Twilio API on courier and how to pass the SID of the template instead of the name
contains and requires #5158