Add Twilio content template type #5183
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5183 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 469 470 +1
Lines 24973 25066 +93
=========================================
+ Hits 24973 25066 +93 ☔ View full report in Codecov by Sentry. |
norkans7
force-pushed
the
twilio-templates-sync
branch
from
24edff0
to
07f8087
Compare
norkans7
changed the title
temba/templates/types/twilio/type.py
Outdated
|
|
||
| class TwilioType(TemplateType): | ||
| slug = "whatsapp" | ||
| variable_regex = re.compile(r"{{(\d+)}}") |
There was a problem hiding this comment.
Twilio allows alphanumeric variables https://www.twilio.com/docs/content/using-variables-with-content-api
temba/templates/types/twilio/type.py
Outdated
| } | ||
| ) | ||
| elif content_type == "twilio/call-to-action": | ||
| button_type = action["type"].upper() |
There was a problem hiding this comment.
unless the Twilio docs say that type is sometimes one case and sometimes another.. don't add ambiguity
temba/templates/types/twilio/type.py
Outdated
|
|
||
| class TwilioType(TemplateType): | ||
| slug = "whatsapp" | ||
| variable_regex = re.compile(r"{{[ ]*([A-Za-z0-9]+)[ ]*}}") |
There was a problem hiding this comment.
it specifically says on https://www.twilio.com/docs/content/using-variables-with-content-api that they can't have spaces
(also [ ]* is not how you match whitespace in a regex)
norkans7
force-pushed
the
twilio-templates-sync
branch
from
2a355d6
to
3199fab
Compare
| "1": 0, | ||
| "3": 1, | ||
| }, | ||
| "params": [{"type": "text"}, {"type": "text"}], |
There was a problem hiding this comment.
I just removed that, that was deprecated and I thought we needed that until the editor was updated, the editor has not been already updated now.
No description provided.