Mailroom client should use content-type header on responses to know whether to parse as JSON #5249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: temba/mailroom/client.py
Did you find this useful? React with a 👍 or 👎 |
rowanseymour
force-pushed
the
mailroom_client_json
branch
3 times, most recently
from
e529c8f
to
3208410
Compare
rowanseymour
commented
May 23, 2024
| @@ -51,27 +47,6 @@ def raise_for_status(self): | |||
| raise HTTPError(request=self.request, response=self) | |||
|
|
|||
|
|
|||
| class MockPost: | |||
rowanseymour
force-pushed
the
mailroom_client_json
branch
from
3208410
to
552ee14
Compare
…hether to parse as JSON
rowanseymour
force-pushed
the
mailroom_client_json
branch
from
552ee14
to
c427867
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5249 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 474 474
Lines 25036 25124 +88
=========================================
+ Hits 25036 25124 +88 ☔ View full report in Codecov by Sentry. |
norkans7
approved these changes
May 24, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And for convenience added
MockJsonResponsefor tests.