Retry ES Calls using httpx #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #28 +/- ##
==========================================
+ Coverage 77.36% 78.57% +1.20%
==========================================
Files 1 1
Lines 190 210 +20
==========================================
+ Hits 147 165 +18
- Misses 24 25 +1
- Partials 19 20 +1
Continue to review full report at Codecov.
|
rowanseymour
requested changes
Aug 24, 2020
rowanseymour
requested changes
Aug 24, 2020
indexer.go
Outdated
| @@ -132,7 +165,7 @@ func CleanupIndexes(url string, alias string) error { | |||
| func MakeJSONRequest(method string, url string, body string, jsonStruct interface{}) (*http.Response, error) { | |||
| req, _ := http.NewRequest(method, url, bytes.NewReader([]byte(body))) | |||
| req.Header.Add("Content-Type", "application/json") | |||
| resp, err := http.DefaultClient.Do(req) | |||
| resp, err := httpx.Do(http.DefaultClient, req, ElasticRetries(), nil) | |||
There was a problem hiding this comment.
but now we're back to creating the retry config for every request 😄
my thinking was one global var called retryConfig, initialize that in init() and use it for all requests
|
haha whoops, ok now I know what you meant. |
rowanseymour
approved these changes
Aug 24, 2020
|
@tybritten I've merged this and it's part of 5.7.1 but so is #29 which you can only run if your RapidPro instance is up to date with our 5.7 branch... we're making a lot of changes this week |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.