Fix Python3, unorderable types: NoneType() > int() #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smartmin/views.py
Outdated
| if self.request.user.id is not None: | ||
| # auto populate modified_by if it is present | ||
| if hasattr(obj, 'modified_by_id') and self.request.user.id >= 0: | ||
| obj.modified_by = self.request.user |
There was a problem hiding this comment.
I think you can simplify as if self.request.user.id and hasattr(obj, 'modified_by_id'), no?
There was a problem hiding this comment.
was not sure if we request.user.id == 0 is a special use case ? so left that code unchanged
There was a problem hiding this comment.
Actually I just looked on prod and AnonymousUser is in there with id -1 - so I think the intention here was to exclude them. So maybe...
if self.request.user.id and self.request.user.id > 0 and hasattr(obj, 'modified_by_id')
dodobas
force-pushed
the
py3_unorderable_types
branch
from
725fe30
to
09440f1
Compare
dodobas
force-pushed
the
py3_unorderable_types
branch
from
09440f1
to
7307308
Compare
rowanseymour
approved these changes
Feb 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.