馃専 Add support for Django2.0 #121
Conversation
| @@ -28,7 +28,7 @@ def process_response(self, request, response): | |||
|
|
|||
|
|
|||
| class ProfileMiddleware(MiddlewareMixin): | |||
| def __init__(self): | |||
| def __init__(self, get_response=None): | |||
| pass | |||
|
|
|||
| def process_view(self, request, view, *args, **kwargs): | |||
There was a problem hiding this comment.
This middleware should be updated
| @@ -28,7 +28,7 @@ def process_response(self, request, response): | |||
|
|
|||
|
|
|||
| class ProfileMiddleware(MiddlewareMixin): | |||
There was a problem hiding this comment.
MiddlewareMixin is no longer needed
.travis.yml
Outdated
| - DJANGO_VERSION=1.11.2 | ||
| - DJANGO_VERSION=1.10.8 | ||
| - DJANGO_VERSION=1.11.14 | ||
| - DJANGO_VERSION=2.0.7 |
There was a problem hiding this comment.
Think we can drop support for Python 2.7 and Django 1.10
README.md
Outdated
| @@ -22,7 +22,7 @@ Smartmin tries to stay in lock step with the latest Django versions. With each n | |||
| will be released and we will save the major changes (possibly breaking backwards compatibility) on these versions. This | |||
| includes updating to the latest version of Twitter Bootstrap. | |||
|
|
|||
| The latest version is the 1.11.* series which works against Django 1.9, 1.10 and 1.11. | |||
| The latest version is the 2.0.* series which works against Django 1.10, 1.11 and 2.0. | |||
| @@ -904,7 +904,7 @@ def test_lockout(self): | |||
| # try to log in four times | |||
| for i in range(4): | |||
| response = self.client.post(login_url, post_data) | |||
| self.assertFalse(response.context['user'].is_authenticated()) | |||
| self.assertFalse(response.context['user'].is_authenticated) | |||
There was a problem hiding this comment.
so this was a method in Django 1.x but a field in Django 2.x? Problem with this test is that if is_authenticated is a method.. then is always true.. I don't get how this is working...
There was a problem hiding this comment.
assertFalse is a simple truthy check if cond: ... and a is_authenticated method is not 'undefined' so it's always 'true'
There was a problem hiding this comment.
Ok I just poked around the Django src and it seems is_authenticated has been a property for a while - but it returns a magical CallableFalse which can also be called. Makes sense now.
dodobas
force-pushed
the
support_django2
branch
2 times, most recently
from
ea236e3
to
b5ec057
Compare
|
Closes #120 |
No description provided.