Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃枍 Stop embedding refresh code on pages that don't have View.refresh set #123

Merged
merged 2 commits into from
Sep 13, 2018

Conversation

dodobas
Copy link
Contributor

@dodobas dodobas commented Sep 12, 2018

No description provided.

@nicpottier
Copy link
Collaborator

Nice, so what's the vector here for XSS? And is it still present for pages that DO have refresh?

@dodobas
Copy link
Contributor Author

dodobas commented Sep 12, 2018

I'm assuming that an attack only makes sense on public pages (anon users). An attacker could embed code by crafting a special link to execute a script that would steal session of a new user, when they register.

For other pages with refresh, depends on who/what generates the refresh url, if it's a free form user input then yeah, it's still open to exploit

@nicpottier
Copy link
Collaborator

ok, ya, seems like a reasonable first step.

@rowanseymour rowanseymour merged commit d1189fc into master Sep 13, 2018
@rowanseymour rowanseymour deleted the xss_fixes branch September 13, 2018 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants