Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python 3 Issues #82

Merged
merged 2 commits into from
Oct 14, 2016
Merged

Python 3 Issues #82

merged 2 commits into from
Oct 14, 2016

Conversation

rowanseymour
Copy link
Member

@rowanseymour rowanseymour commented Oct 14, 2016 •
edited

  • Fix use of unicode and add test for ImageThumbnailWidget
  • Fix modifying dict during iteration

@rowanseymour rowanseymour self-assigned this Oct 14, 2016
@rowanseymour rowanseymour changed the title Fix use of unicode(..) and add test for ImageThumbnailWidget Python 3 Issues Oct 14, 2016
norkans7
norkans7 approved these changes Oct 14, 2016
View reviewed changes
Copy link
Contributor

@norkans7 norkans7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep

nicpottier
nicpottier approved these changes Oct 14, 2016
View reviewed changes
Copy link
Collaborator

@nicpottier nicpottier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍼

@rowanseymour rowanseymour merged commit 403c226 into master Oct 14, 2016
@rowanseymour rowanseymour deleted the python3_fix branch October 14, 2016 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicpottier nicpottier nicpottier approved these changes

@norkans7 norkans7 norkans7 approved these changes

Assignees

@rowanseymour rowanseymour

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rowanseymour @nicpottier @norkans7