ensure import filename length cannot exceed 100 characters #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rowanseymour
reviewed
Nov 9, 2016
| @@ -8,8 +10,16 @@ | |||
| from smartmin.models import SmartModel | |||
|
|
|||
|
|
|||
| def generate_file_path(instance, filename): | |||
There was a problem hiding this comment.
What's the reason for this change? Should we be using a random file name instead to ensure uniqueness?
There was a problem hiding this comment.
here I want to make sure the length is not exceeding 64 to prevent https://sentry.io/nyaruka/textit/issues/178987795/
yep I was going to investigate how the uniqueness of name is done on django
There was a problem hiding this comment.
@rowanseymour I verified this is safe django always makes sure the file names are unique by appending 8 characters to the file name
norkans7
commented
Nov 9, 2016
| @@ -1,4 +1,4 @@ | |||
| celery | |||
| celery<4.0.0 | |||
There was a problem hiding this comment.
celery 4.0.0 requires django 1.8 I pin this way to keep supporting django 1.7
norkans7
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.