compose - switch to media api for attachment upload #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove type from Attachment interface - switch from msgmedia/upload to api/v2/media in progress nyaruka/rapidpro#4347
- updated postFormData, for a rejected promise, to pass the string response.body if/when available, but if not, to continue to pass the string 'Server failure' - updated the catch block to process the error json file array to display the first err msg in the array if/when available, but if not, to display the initial error string nyaruka/rapidpro#4347
- added error handling for both django and nginx errors to compose component - added check for upload endpoint when rejecting a promise, and passing the full response back, while maintaining status quo and passing the 'Server failure' string back for everything else nyaruka/rapidpro#4347
Codecov Report
@@ Coverage Diff @@
## main #276 +/- ##
==========================================
- Coverage 79.41% 79.38% -0.04%
==========================================
Files 67 67
Lines 17467 17476 +9
Branches 593 592 -1
==========================================
+ Hits 13872 13873 +1
- Misses 3588 3596 +8
Partials 7 7
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
AFTER - happy path - successfully uploaded attachment AFTER - django error due to file unsupported file type AFTER - django error due to file exceeding max file size, but less than nginx max file size AFTER - nginx error due to file exceeding max file size |
rowanseymour
requested changes
Mar 3, 2023
- remove console.error() - minor cleanup of comments
susanm74
changed the title
ericnewcomer
deleted the
sl-compose-switch-to-media-api-for-attachment-uploads
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes nyaruka/rapidpro#4347