add DOHMH rodent inspections dataset #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austensen
added a commit
to JustFixNYC/nycdb-k8s-loader
that referenced
this pull request
Jun 25, 2024
This PR adds a new custom dataset/job for building all the signature dashboard tables. It follows the same pattern as we used for OCA address level data (which itself was adapted from the custom wow job). There's unfortunately a fair bit of repetition with the <dataset>util.py functions for these three - but I think that can be addressed in future, ideally with a bigger change since a lot of this approach loading wow code into here is not great in general. I have also updated the WOW version in the Dockerfile to use the last commit on the signature-dashboard branch (JustFixNYC/who-owns-what#938) This also updates the NYCDB version to include a bunch of recent PRs adding/updating datasets that are used in signature, and adds these to cron scheduling. (I've already added these datasets manually to the demo DB for signature dev, and once this is merged I'll add the k8s cron jobs for the prod DB) add indexes on boundaries, construct geom on pluto_latest nycdb/nycdb#330 add dataset for HPD Alternative Enforcement Program (AEP) nycdb/nycdb#331 Update HPD CONH dataset for schema change nycdb/nycdb#332 add dataset for HPD underlying conditions program nycdb/nycdb#333 add fee charges, consolidate omo/hwo into hpd_charges nycdb/nycdb#334 add new fields to dob_safety_violations nycdb/nycdb#336 add DOHMH rodent inspections dataset nycdb/nycdb#337 update boundaries to version 24b nycdb/nycdb#338
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the DOHMH's Rodent Inspections dataset
While working on this I caught a bug in
typecast.time(), that wasn't handling 12pm correctly, causing nulls. I've simplified the approach and added some addition tests.