FIX PHP 5.3.0 compatibility fix

Changed to instanceof instead of is_a to be compatibile with <5.3.9
nyeholt · Oct 8, 2015 · 83e484a · 83e484a
1 parent 30b07c9
commit 83e484a
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/code/services/PermissionService.php b/code/services/PermissionService.php
@@ -388,18 +388,18 @@ public function checkPerm(DataObject $node, $perm, $member=null) {
 					}
 
 					$grant = null;
-					if (is_a($access->Type, 'Group', true)) {
+					$authority = $access->getAuthority();
+					if ($authority instanceof Group) {
 						if (isset($gids[$access->AuthorityID])) {
 							$grant = $access->Grant;
 						}
-					} else if (is_a($access->Type, 'Member', true)) {
+					} else if ($authority instanceof Member) {
 						if ($member->ID == $access->AuthorityID) {
 							$grant = $access->Grant;
 						}
 					} else {
 						// another mechanism that will require a lookup of members in a list
 						// TODO cache this
-						$authority = $access->getAuthority();
 						if ($authority instanceof ListOfMembers) {
 							$listMembers = $authority->getAllMembers()->map('ID', 'Title');
 							if (isset($listMembers[$member->ID])) {