Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: email thread would collapse if the header or body would be clicked. #474

Conversation

AaronDDM
Copy link
Collaborator

@AaronDDM AaronDDM commented Sep 8, 2023

Code changes

  • Added a new "mousedown" handler for detecting text selection highlight attempts to prevent message thread handlers from firing.
  • Moved the thread click handlers to only the parts of the UI that need it (instead of the whole thread container).
Screen.Recording.2023-09-08.at.1.29.59.PM.mov

License

I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@vercel
Copy link

vercel bot commented Sep 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
components ❌ Failed (Inspect) Sep 8, 2023 5:37pm

@AaronDDM AaronDDM self-assigned this Sep 8, 2023
Fix: unable to highlight text in the header if attempting to copy/paste.
@AaronDDM AaronDDM force-pushed the CUST-1951-components-unable-to-copy-paste-text-on-email-component-part-2 branch from ea9750b to 6476b4f Compare September 8, 2023 17:37
@AaronDDM AaronDDM merged commit cf60017 into main Sep 8, 2023
5 of 6 checks passed
@AaronDDM AaronDDM deleted the CUST-1951-components-unable-to-copy-paste-text-on-email-component-part-2 branch September 8, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants