[58500] Python SDK support for metadata for events #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'metadata_key' and 'metadata_value' can already be filtered by passing them in as an array. 'metadata_pair' is now supported by passing in a dict
|
This pull request has been linked to Clubhouse Story #58500: Python SDK support for metadata for events. |
philrenaud
reviewed
May 18, 2021
There was a problem hiding this comment.
You'll need to run python Black locally to format things (it may just be upset about your import order; unsure)
And ideally you could add some tests to https://github.com/nylas/nylas-python/blob/main/tests/test_events.py here as well
Added extra logic in the mock_events function to be able to mimic filtering using the 3 different types of metadata filters; `metadata_key`, `metadata_value`, and `metadata_pair`
@philrenaud Black was re-ran and tests were added! |
philrenaud
approved these changes
May 18, 2021
Merged
mrashed-dev
added a commit
that referenced
this pull request
Jul 21, 2021
New `nylas` v5.0.0 release bringing in the following additions: * Add support for the Nylas Neural API (#163) * Add `metadata` support (#152) * Add new Room Resource fields (#156) * Add `Nylas-API-Version` header support (#157, #151) as well as the following changes: * Transitioned from `app_id` and `app_secret` naming to `client_id` and `client_secret` (#159, #86) * Fix adding a tracking object to an existing `draft` (#153) * Fix issue when converting offset-aware `datetime` objects to `timestamp` (#154, #143) * Fix `limit` value in filter not being used when making `.all()` call (#155) * Fix `from_` field set by attribute on draft ignored (#162, #160) * Remove `bumpversion` from a required dependency to an extra dependency (#158, #144)
mrashed-dev
deleted the
mostafarashed/ch58500/python-sdk-support-for-metadata-for-events
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Nylas Calendar API has a new beta feature of adding a new metadata field to calendar events. This PR makes the feature available via the Nylas Python SDK.
Usage
To filter using either
metadata_keyormetadata_valueyou can pass in a string:events = nylas.events.where(metadata_key='hello').all()or, you can pass in multiple strings as an array:
events = nylas.events.where(metadata_value=['value1', 'value2']).all()To filter on
metadata_pairyou can pass in adictof key-value pairs to use in the query:events = nylas.events.where(metadata_pair={'hello': 'world'}).all()License
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.