[62378] Updated credential naming to be consistent with the API and other SDKs #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Transitioned from `app_id` and `app_secret` to `client_id` and `client_secret` to match the naming of what we use in the API and across all the other SDKs.
|
This pull request has been linked to Clubhouse Story #62378: Credentials naming should be consistent. |
…uld-be-consistent
mrashed-dev
deleted the
mostafarashed/ch62378/credentials-naming-should-be-consistent
branch
Merged
mrashed-dev
added a commit
that referenced
this pull request
Jul 21, 2021
New `nylas` v5.0.0 release bringing in the following additions: * Add support for the Nylas Neural API (#163) * Add `metadata` support (#152) * Add new Room Resource fields (#156) * Add `Nylas-API-Version` header support (#157, #151) as well as the following changes: * Transitioned from `app_id` and `app_secret` naming to `client_id` and `client_secret` (#159, #86) * Fix adding a tracking object to an existing `draft` (#153) * Fix issue when converting offset-aware `datetime` objects to `timestamp` (#154, #143) * Fix `limit` value in filter not being used when making `.all()` call (#155) * Fix `from_` field set by attribute on draft ignored (#162, #160) * Remove `bumpversion` from a required dependency to an extra dependency (#158, #144)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion
In the other Nylas components like the API and Dashboard, as well as the other SDKs, the credentials are referred to as
client_idandclient_secrethowever this SDK was referring to these credentials asapp_idandapp_secret. This causes some unnecessary confusion, and this change addresses this by switching all references ofapp_idandapp_secrettoclient_idandclient_secret.Usage
If you were previously initializing
APIClientby passing in the credentials as a variable assignment, you are required to update your code to reflect the new credential variable names:If you were initializing it by just passing in the values in order like so:
then no change is required on your part.
License
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.