-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v6.0.0 #460
Merged
Merged
v6.0.0 #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* AV-1468 Purge collections and models * new design * FIRST WORKING API CALL!!! * update * quik cfix * testing file * refactor http handling for resources * node sdk parity * refactor * refactor * application + redirect_uris * scopes * fix * more fix * fixes * more fix --------- Co-authored-by: Mostafa Rashed <17770919+mrashed-dev@users.noreply.github.com>
This PR: * adds Yard documentation * cleans up typos and just code tidy * Update dependencies and gemspec * Update readme * Repo cleanup * Bug fixes
This PR is for releasing the first beta of v6 on RubyGems.
This PR adds an upgrade doc, updates the readme, adds more error classes and a default timeout. Co-authored-by: Lrubin <Lrubin@nylas.com>
* Update README for Hacktoberfest (#427) add blurb on hacktoberfest guidelines * Fix Rubocop complains None of them related to my code, but everything is fixed and tested * Remove hackathon blurb --------- Co-authored-by: Mostafa Rashed <17770919+mrashed-dev@users.noreply.github.com>
…Is (#431) Adds support for custom authentication, the connectors API and the credentials API.
This PR adds support for the Folders API
This PR adds support to messages, threads, drafts, and send.
This PR adds support for the Attachments API
* Added additional error classes (#426) * Added support for free/busy endpoint (#428) * Added support for Messages, Drafts, and Smart Compose APIs (#432) * Added support for custom authentication, connectors, and credentials APIs (#431) * Added support for folders API (#433) * Added support for attachments API (#434) * Set default timeout to 30 seconds (#426)
This PR fixes a bug that arises when sending messages and creating or modifying drafts without any attachments present.
The endpoint for free-busy was "availability" when it should be "free-busy"
This PR adds support for the contacts API.
Adding "send" to the drafts endpoint
Added webhook triggers for: * Message Opened * Message Link Clicked * Thread Replied
Tw 2456 ruby add send to drafts
Added send-rsvp support for events api
There is a syntax error when calling build_query.
* Update CHANGELOG.md * linting * bump ver * Update CHANGELOG.md
List and Find Scheduled messages are mixed up
This PR fixes the PKCE code challenge generation; the correct method the API wants is for us to base64 encode the hex string as opposed to base64 encoding resulting hashed bytearray directly.
We were encoding our URL prematurely, causing an error to be thrown when setting additional parameters (PKCE, etc.)
Increase code coverage to ~100%. Fixes were also completed: * **BREAKING CHANGE**: Renamed `Applications.info()` to `Applications.get_details()` for consistency * **BREAKING CHANGE**: Changed return type of `Auth.url_for_oauth2_pkce()` from `OpenStruct` to a hash for consistency * Added support for detecting providers * Added enhanced support for the `Webhooks` API * Default `client_secret` to the configured `api_key` for token exchange methods if not provided * Fixed construction of query parameters * Fixed construction of OAuth2 URL * Fixed typo in paths for `Grants` class
# Changelog * **BREAKING CHANGE**: Renamed `Applications.info()` to `Applications.get_details()` for consistency * **BREAKING CHANGE**: Changed return type of `Auth.url_for_oauth2_pkce()` from `OpenStruct` to a hash for consistency * Added support for detecting providers * Added enhanced support for the `Webhooks` API * Default `client_secret` to the configured `api_key` for token exchange methods if not provided * Fixed list and find scheduled messages * Fixed incorrect PKCE code challenge generation * Fixed incompatible types when building OAuth2 URL * Fixed construction of query parameters * Fixed construction of OAuth2 URL * Fixed typo in paths for `Grants` class
AaronDDM
approved these changes
Feb 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is a culmination of all the PRs that contained v6-related development, with formal support for the Nylas API v3. This release is essentially the same as the v6.0.0.beta.4 release found on rubygems. Please refer to the readme for a quick start guide on using the new SDK, as well as links to the upgrade doc as well as the SDK reference docs.
Changelog
License
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.