Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Config version does not correspond to binary version #3434

Closed
simonwicky opened this issue May 19, 2023 · 1 comment
Closed

[Bug] Config version does not correspond to binary version #3434

simonwicky opened this issue May 19, 2023 · 1 comment
Assignees
@jstuczyn @tommyv1987
Labels
bug Something isn't working bug-needs-triage A bug that needs discussing and triage qa Quality Assurance
Milestone
2023.25

Comments

@simonwicky
Copy link
Contributor

Issue
Simple client generation on nym-binaries-v1.1.19 suggests a binary version of 1.1.17, but generates a config file indicating version 1.1.14.

Steps to reproduce
Run a fresh init for a client on nym-binaries-v1.1.19.

Command output
Capture d’écran 2023-05-19 à 15 43 48

Generated config file
Capture d’écran 2023-05-19 à 15 45 00
@simonwicky simonwicky added bug Something isn't working bug-needs-triage A bug that needs discussing and triage qa Quality Assurance labels May 19, 2023
@jstuczyn
Copy link
Contributor

note for future self: this is because we're pulling version of client-core to populate the field

@octol octol mentioned this issue May 24, 2023
Closed
@jstuczyn jstuczyn self-assigned this Jun 6, 2023
@jstuczyn jstuczyn added this to the 2023.24 milestone Jun 6, 2023
jstuczyn added a commit that referenced this issue Jun 6, 2023
@jstuczyn
bugfix #3434
d645bf9
@jstuczyn jstuczyn mentioned this issue Jun 6, 2023
Merged
1 task
jstuczyn added a commit that referenced this issue Jun 7, 2023
@jstuczyn
bugfix #3434
a94da30
jstuczyn added a commit that referenced this issue Jun 7, 2023
@jstuczyn
bugfix #3434
e3806ab
jstuczyn added a commit that referenced this issue Jun 9, 2023
@jstuczyn
bugfix #3434
31b7921
@tommyv1987 tommyv1987 modified the milestones: 2023.24, 2023.25 Jun 12, 2023
tommyv1987 added a commit that referenced this issue Jun 14, 2023
@tommyv1987
Merge pull request #3520 from nymtech/bugfix/incorrect-client-versions
dd33052 
bugfix #3434
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jstuczyn jstuczyn

@tommyv1987 tommyv1987

Labels
bug Something isn't working bug-needs-triage A bug that needs discussing and triage qa Quality Assurance
Projects
Core systems
Status: Done
Milestone
2023.25
Development

No branches or pull requests
4 participants
@jstuczyn @simonwicky @benedettadavico @tommyv1987