Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/pedersen-commitments #1048

Merged
merged 55 commits into from
Mar 11, 2022
Merged

feature/pedersen-commitments #1048

merged 55 commits into from
Mar 11, 2022

Conversation

danielementary
Copy link
Contributor

Replace original ElGamal encryption with Pedersen commitments for blind signatures.

danielementary and others added 30 commits December 20, 2021 16:39
@danielementary
add pedersen.rs and first alias type
a88be3d
@danielementary
replace ciphertexts in BlindSignRequest by commitments and adapt try_…
70f010d 
…from
@danielementary
update BlindSignRequest.to_byte_vec
15c4698
@danielementary
add TODO to issuance.rs
b063792
@danielementary
[WIP] update CmCs proof to use commitments
90af724
@danielementary
complete ProofCmCs construct implementation
978557b
@danielementary
[WIP] ProofCmCs verify
e36d621
@danielementary
complete ProofCmCs verify implementation
cefd289
@danielementary
complete ProofCmCs to_bytes implementation
42a8c04
@danielementary
complete ProofCmCs from_bytes implementation
4c6ed27
@danielementary
WIP update ProofCmCs roundtrip tests
5cb2787
@danielementary
WIP update prepare_blind_sign
181f71a
@danielementary
update prepare_blind_sign
d7db819
@danielementary
WIP update blind_sign
404d4b8
@danielementary
update blind_sign
da94f0d
@danielementary
update BlindedSignature and try_from
694c4a1
@danielementary
update BlindedSignature unblind
dcf0572
@danielementary
update BlindedSignature to_bytes
4d07b9f
@danielementary
move elgamal encrypto to elgamal and manage imports
4c81ee1
@danielementary
add verification keys for g1 method
53a09ad
@danielementary
upadate tests to work with Pedersen commitments
9ba550e
@danielementary
unused remove pedersen.rs
6ba9fca
@danielementary
update error message
690f83c
@danielementary
fix proof_cm_cs_bytes_roundtrip test
5b2dfbc
@aniampio
Move generation of commitment openings into prepare blind signature f…
d34433a 
…unction
@aniampio
Edits
14fc663
@aniampio
Extende the verification key; remove validator's secret key from the …
ba9ad4d 
…unblind function
@aniampio
Update the unblind function throughout the whole nymcoconut repo
500789b
@aniampio
Fix broken tests
184e8cc
@aniampio
Run cargo clippy and fmt
3c441f1
@danielementary danielementary marked this pull request as ready for review January 19, 2022 09:10
jstuczyn
jstuczyn reviewed Jan 19, 2022
View reviewed changes
Copy link
Contributor

@jstuczyn jstuczyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't really say anything about the correctness of the crypto itself, but I assume you and @aniampio verified it's correct.

There's couple of tiny changes that you might (or not) want to introduce.

Also, since it changes how our coconut works, do we want to be merging that into develop or should we keep it in separate branch? @futurechimp @mmsinclair ? Perhaps we could still merge it since coconut is not really used anywhere just yet?

common/nymcoconut/src/elgamal.rs Show resolved Hide resolved
common/nymcoconut/src/proofs/mod.rs Show resolved Hide resolved
common/nymcoconut/src/proofs/mod.rs Outdated Show resolved Hide resolved
common/nymcoconut/src/scheme/issuance.rs Outdated Show resolved Hide resolved
common/nymcoconut/src/scheme/keygen.rs Show resolved Hide resolved
common/nymcoconut/src/scheme/verification.rs Outdated Show resolved Hide resolved
@jstuczyn jstuczyn linked an issue Jan 24, 2022 that may be closed by this pull request
[Coconut]: Replace ElGamal with Pedersen commitments #901
Closed
neacsu
neacsu reviewed Jan 27, 2022
View reviewed changes
common/nymcoconut/src/proofs/mod.rs Show resolved Hide resolved
common/nymcoconut/src/scheme/mod.rs Outdated Show resolved Hide resolved
@aniampio aniampio requested a review from neacsu March 10, 2022 18:15
neacsu
neacsu approved these changes Mar 11, 2022
View reviewed changes
Copy link
Contributor

@neacsu neacsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Is there something specific that needs to be done when generating keys, using for example https://github.com/nymtech/coconut/tree/develop/keygen-cli ?

common/nymcoconut/src/scheme/keygen.rs Outdated Show resolved Hide resolved
@aniampio aniampio merged commit c7cdd1e into nymtech:develop Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstuczyn jstuczyn jstuczyn left review comments

@aniampio aniampio aniampio left review comments

@neacsu neacsu neacsu approved these changes

@durch durch Awaiting requested review from durch

@futurechimp futurechimp Awaiting requested review from futurechimp

@octol octol Awaiting requested review from octol

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Coconut]: Replace ElGamal with Pedersen commitments
4 participants
@danielementary @jstuczyn @aniampio @neacsu