Feature/add topology to validator #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstuczyn
requested changes
Mar 17, 2020
| service_providers: Vec::<presence::ServiceProvider>::new(), | ||
| validators: Vec::<presence::Validator>::new(), | ||
| }; | ||
| let response = serde_json::to_string_pretty(&topology).unwrap(); |
There was a problem hiding this comment.
Any reason we prettify the response rather than just use to_string ?
There was a problem hiding this comment.
I just like emitting pretty json wherever possible.
validator/Cargo.toml
Outdated
| serde = "1.0.104" | ||
| serde_derive = "1.0.104" |
There was a problem hiding this comment.
We definitely don't need to import serde_derive as seperate dependency as everything is already included in base serde (as long as we use correct features). I think the same might be true for serde_json but I haven't tested that claim
There was a problem hiding this comment.
Good catch on the dervive. It looks the serde_json is needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.