New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Client: multiplex connection data streams #1720
Merged
octol
merged 26 commits into
develop
from
jon/feat/multiplex-connections-out-queue-controller
Nov 11, 2022
Merged
Client: multiplex connection data streams #1720
octol
merged 26 commits into
develop
from
jon/feat/multiplex-connections-out-queue-controller
Nov 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octol
changed the title
SOCKS5: multiplex outgoing connections in out queue controller
SOCKS5: multiplex connections
Nov 2, 2022
jstuczyn
reviewed
Nov 7, 2022
.../src/client/real_messages_control/acknowledgement_control/retransmission_request_listener.rs
Show resolved
Hide resolved
clients/client-core/src/client/real_messages_control/real_traffic_stream.rs
Outdated
Show resolved
Hide resolved
clients/client-core/src/client/real_messages_control/real_traffic_stream.rs
Outdated
Show resolved
Hide resolved
clients/client-core/src/client/real_messages_control/real_traffic_stream.rs
Outdated
Show resolved
Hide resolved
clients/client-core/src/client/real_messages_control/real_traffic_stream.rs
Outdated
Show resolved
Hide resolved
clients/client-core/src/client/real_messages_control/real_traffic_stream.rs
Outdated
Show resolved
Hide resolved
clients/client-core/src/client/real_messages_control/real_traffic_stream.rs
Show resolved
Hide resolved
octol
requested review from
durch,
futurechimp,
neacsu and
mmsinclair
as code owners
November 7, 2022 13:55
octol
force-pushed
the
jon/feat/multiplex-connections-out-queue-controller
branch
from
November 10, 2022 00:01
daf03e9
to
50a009d
Compare
octol
changed the title
Client: multiplex connections
Client: multiplex connection data streams
Nov 11, 2022
octol
force-pushed
the
jon/feat/multiplex-connections-out-queue-controller
branch
from
November 11, 2022 09:27
f805a10
to
dade30c
Compare
octol
deleted the
jon/feat/multiplex-connections-out-queue-controller
branch
November 11, 2022 10:04
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #1939
Part of: #1960
Transmission lanes
Introduces the concept of
TransmissionLanes
inclient-core
.The idea is that the
OutQueueControl
will multiplex sphinx packets according to these categories. Large data transfers will not block other connections, and smaller messages will be given priority.Tagging messages
The SOCKS5 client will tag sent messages accordingly, and is relatively straightforward as it owns the whole pipeline from incoming TCP connection to transmitting sphinx packets to the gateway via the
gateway-client
.The
network-requester
however, will need to modifyClientRequest
to append aconnection_id
toClientRequest::Send
, as well as add another message type,ClientRequest::CloseConnection(..)
.Connection handling in the
OutQueueControl
Because there might be a not insignificant delay between accepting TCP connections and transmitting the sphinx packets, depending on load, the
OutQueueControl
needs to be able to discard packets destined for a stale and closed connection.Message priority in
OutQueueControl
Initially a very rudimentary heuristic is used to prioritize packets in the
OutQueueControl
, where small packets will be sent first.Testing
Confirmed in keybase that:
curl --socks5-hostname localhost:1080 https://nymtech.net/.wellknown/connect/healthcheck.json
does not affect each other (too much)
TODO
nym-socks5-client
nym-network-requester
Checklist:
CHANGELOG.md