Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming validator-api to nym-api #1863

Merged
merged 22 commits into from Dec 14, 2022
Merged

Renaming validator-api to nym-api #1863

merged 22 commits into from Dec 14, 2022

Conversation

futurechimp
Copy link
Contributor

Description

Closes: team-core#214

Renames validator-api to nym-api.

Checklist:

  • [*] added a changelog entry to CHANGELOG.md

@futurechimp
Copy link
Contributor Author

Ok I think this develop merge should do the trick - can you have a look @jstuczyn and @octol ?

@futurechimp
Copy link
Contributor Author

Lots more changes done. Everything compiles nicely now, and except in TypeScript client I think most things have renamed.

Please don't merge this to develop as we need to talk about whether updating config file keys is going to break old clients (I suspect it will). We will need to figure out a good upgrade process.

@jstuczyn
Copy link
Contributor

Lots more changes done. Everything compiles nicely now, and except in TypeScript client I think most things have renamed.

Please don't merge this to develop as we need to talk about whether updating config file keys is going to break old clients (I suspect it will). We will need to figure out a good upgrade process.

you can use #[serde(alias = "old-name")] to preserve compatibility

@futurechimp
Copy link
Contributor Author

Ok I've tested out 1.1.x config files with validator_api_urls in them, as well as the new key nym_api_urls. Deserialization works well in both cases.

I'll leave it here for the afternoon in case anyone can think of other stuff which could break (currently I can't think of any)

@futurechimp futurechimp merged commit f6a79ce into develop Dec 14, 2022
@futurechimp futurechimp deleted the feature/rename-nym-api branch December 14, 2022 15:05
mmsinclair pushed a commit that referenced this pull request Dec 19, 2022
* Renaming validator-api to nym-api

* nym-api: simplified crate name

* Added nym-api rename to changelog

* Changed some output messages

* Renamed validator-api-requests to nym-api requests

* Removing more references to validator-api-requests

* Additional lockfile name changes after full build

* Removing mistakenly added merge files

* ibid

* ibid

* Getting rid of ref to validator_api deep inside validator-client

* Fixing file storage paths

* Renaming struct function names referring to validator_api

* Simplifying struct init

* Fixed up all other instances of nym_api.

* Renaming validatorApi to nymApi in TypeScript client for consistency

v

* Found a few more Rust instances

* Changed examples in TypeScript SDK

* Found one more instance of the use of validator instead of nym apis

* Aliasing config key name for deserialization to preserve compatibility with old configs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants