Feature/packet retransmission #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstuczyn
commented
Jun 12, 2020
| use rand_distr::{Distribution, Exp}; | ||
| use std::time; | ||
|
|
||
| // TODO: ask @AP why we are actually using Distribution::Exp(1/L) rather than just |
There was a problem hiding this comment.
@aniampio I'm almost certain I've already asked this when we were initially working on Sphinx, but could you explain it again?
jstuczyn
commented
Jun 12, 2020
| .ok_or_else(|| MixProcessingError::InvalidPayload)?; | ||
| let (payload_destination, message) = | ||
| payload.try_recover_destination_and_plaintext()?; | ||
| // TODO: @AP, does that check still make sense? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #164
Initial take on #84 (is not fully implemented as described below)
With the limited testing this seems to work as we wanted. However, there's one limitation of the current approach. If you happen to send a mix message of length 21 bytes, it will not go through - it will be interpreted as an ACK instead.
Do not worry though, this will be resolved with further enhancements we have discussed one of which includes gateway being unable to read plaintext message and padding on them (meaning "real" messages will always have one constant size and it will not be possible to confuse them with acks regardless of their content)
In this branch I've also slightly attacked #256 by telling the client to panic if it detects the gateway went down.