Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make sure to clear inner 'ack_map' in 'GatewaysReader' #3300

Merged
merged 1 commit into from
Apr 20, 2023
Merged

make sure to clear inner 'ack_map' in 'GatewaysReader' #3300

merged 1 commit into from
Apr 20, 2023

Conversation

jstuczyn
Copy link
Contributor

Description

Closes: #XXXX

Checklist:

  • added a changelog entry to CHANGELOG.md

@jstuczyn jstuczyn added the bug Something isn't working label Apr 13, 2023
@jstuczyn jstuczyn added this to In progress in Core systems via automation Apr 13, 2023
@jstuczyn jstuczyn added this to the 2023.17 (v1.1.16) milestone Apr 13, 2023
@jstuczyn jstuczyn moved this from In progress to Deploy to QA in Core systems Apr 13, 2023
@jstuczyn jstuczyn self-assigned this Apr 13, 2023
@tommyv1987 tommyv1987 moved this from Deploy to QA to Docs in Core systems Apr 20, 2023
@tommyv1987 tommyv1987 moved this from Docs to QA in Core systems Apr 20, 2023
@tommyv1987
Copy link
Contributor

tested in qa ->
image
looking good

@tommyv1987
Copy link
Contributor

targeting the next release branch as opposed to develop

@tommyv1987 tommyv1987 changed the base branch from develop to release/v1.1.16 April 20, 2023 07:31
@tommyv1987 tommyv1987 merged commit 926389d into release/v1.1.16 Apr 20, 2023
10 checks passed
Core systems automation moved this from QA to Done Apr 20, 2023
@tommyv1987 tommyv1987 deleted the bugfix/empty-ack-stream-map branch April 20, 2023 07:31
durch added a commit that referenced this pull request Apr 24, 2023
@durch
Squashed commit of the following:
a79fcb0 
commit 16fdfa4
Author: Tommy Verrall <60836166+tommyv1987@users.noreply.github.com>
Date:   Mon Apr 24 13:54:54 2023 +0200

    Update mainnet.env

commit cbbeb66
Author: Jędrzej Stuczyński <jedrzej.stuczynski@gmail.com>
Date:   Mon Apr 24 09:56:26 2023 +0100

    Feature/wasm client topology injection (#3311)

    * added cargo config file to explicitly specify build target

    * wip

    * Config option to disable topology refreshing

    * extracted common parsing code

    * helper trait for working on wasm topology

    * wasm topology parsing

    * restored (slightly modified) old js-example

    * wip

    * Moved message preparation into a trait

    * wip

    * long-winded way of sending test packet

    * standalone NymNodeTester

    * finishing the test upon receiving all packets even if timeout wasnt reached

    * initial round of cleanup

    * sending multiple test packets in normal NymClient

    * javascript-side cleanup

    * starting mixnode test on btn click

    * Improved NymNodeTester constructors

    * improved error handling and constructors

    * tester utils error handling

    * further cleanup + using BTreeMap for NymTopology mixnodes

    * handling missed errors

    * splitting up 'test_node'

    * split up and cleaned up generation of test result

    * clippy + fixed example

    * post rebase fixes

    * another broken test

    * prevent running multiple parallel tests

    * cargo fmt

    * Added nym- prefix to node tester utils

commit f24bb5c
Author: Jędrzej Stuczyński <jedrzej.stuczynski@gmail.com>
Date:   Thu Apr 20 15:25:23 2023 +0100

    reduced noise in CODEOWNERS (#3313)

    * reduced noise in CODEOWNERS

    * Add @octol to codeowners

    * added @mfahampshire as owner of /documentation

    ---------

    Co-authored-by: Jon Häggblad <jon.haggblad@gmail.com>

commit 79dfe7e
Author: Jon Häggblad <jon.haggblad@gmail.com>
Date:   Thu Apr 20 14:13:20 2023 +0200

    Add clippy target in top-level Makefile

commit 0108c6e
Merge: 6e30e61 926389d
Author: Jon Häggblad <jon.haggblad@gmail.com>
Date:   Thu Apr 20 09:55:19 2023 +0200

    Merge remote-tracking branch 'origin/release/v1.1.16' into develop

commit 926389d
Merge: b55db00 7a50f0c
Author: Tommy Verrall <60836166+tommyv1987@users.noreply.github.com>
Date:   Thu Apr 20 08:31:31 2023 +0100

    Merge pull request #3300 from nymtech/bugfix/empty-ack-stream-map

    make sure to clear inner 'ack_map' in 'GatewaysReader'

commit b55db00
Merge: cfcb64f 9549bed
Author: Tommy Verrall <60836166+tommyv1987@users.noreply.github.com>
Date:   Thu Apr 20 07:55:56 2023 +0100

    Merge pull request #3324 from nymtech/bugfix/nym-cli-gateway-commands

    exposed missing gateway commands in nym-cli

commit cfcb64f
Author: Jędrzej Stuczyński <jedrzej.stuczynski@gmail.com>
Date:   Thu Apr 20 07:52:10 2023 +0100

    Feature/reduce pledge (#3254)

    * basic contract work for 'decrease_pledge' functionality

    note: it doesn't yet return tokens back to the operator

    * returning extra tokens after decreasing pledge

    * added vesting message to track pledge decrease

    * attaching the track message when processing delegation decrease

    * checking for zero value request

    * fixed event test

    * allowing to decrease pledge from the vesting contract

    * integration test for the feature

    * reorganised the integration tests

    * updated nyxd client traits

    * wallet support

    * typescript helpers

    * moved 'pledge more' functionality to operator commands

    * cli commands for decreasing pledge

    * changed error variant to make clippy happier

    * removed unused import

    * eslint

    * fixed post-rebase imports

    * added cargo config

    * added PendingMixNodeChanges to MixNodeDetails

    * returning event id after creating it

    * Streamlined getting mixnode details by identity key

    * setting pending pledge changes on increase/decrease

    * clearing the value on resolving the event

    * checking for correct invariants when clearing events

    * further pending events unit tests fixes

    * new unit tests for tx endpoints

    * queries for pending events (by id)

    * migration code

    * using default value for pending changes if unavailable

    * improved integration test assertions

commit 9c6c5f5
Author: Jon Häggblad <jon.haggblad@gmail.com>
Date:   Wed Apr 19 10:44:46 2023 +0200

    Add --all-targets to nym-wallet CI clippy (#3326)

commit f28888e
Author: Jon Häggblad <jon.haggblad@gmail.com>
Date:   Wed Apr 19 09:40:49 2023 +0200

    Update Cargo.lock files after bumping internal versions during 1.1.15 release

commit 6e30e61
Author: Jon Häggblad <jon.haggblad@gmail.com>
Date:   Wed Apr 19 09:37:38 2023 +0200

    Update Cargo.lock files after bumping internal versions during release

commit 9549bed
Author: Jędrzej Stuczyński <jedrzej.stuczynski@gmail.com>
Date:   Tue Apr 18 16:28:13 2023 +0100

    exposed missing gateway commands in nym-cli

commit 7a50f0c
Author: Jędrzej Stuczyński <jedrzej.stuczynski@gmail.com>
Date:   Thu Apr 13 10:51:03 2023 +0100

    make sure to clear inner 'ack_map' in 'GatewaysReader'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@durch durch Awaiting requested review from durch durch is a code owner

@futurechimp futurechimp Awaiting requested review from futurechimp

@neacsu neacsu Awaiting requested review from neacsu neacsu is a code owner

@octol octol Awaiting requested review from octol octol is a code owner

Assignees

@jstuczyn jstuczyn

Labels
bug Something isn't working
Projects
Core systems
Archived in project
Core systems
  
Done
Milestone
2023.17 (v1.1.16)
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jstuczyn @tommyv1987