Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update mix-node setup docs with node description #3325

Merged
merged 1 commit into from
Apr 25, 2023
Merged

update mix-node setup docs with node description #3325

merged 1 commit into from
Apr 25, 2023

Conversation

esomore
Copy link
Contributor

@esomore esomore commented Apr 18, 2023 •
edited

Description

Adding missing instructions on how to add description to a mix-node

Checklist:

  • added a section to mix-node-setup.md

@esomore esomore marked this pull request as ready for review April 18, 2023 17:32
github-actions[bot]
github-actions bot reviewed Apr 18, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making this first PR

@mfahampshire
Copy link
Contributor

Please retarget your PR to be against release/v1.1.16 - the upcoming release.

@mfahampshire mfahampshire added the documentation Improvements or additions to documentation label Apr 19, 2023
@esomore esomore changed the base branch from develop to release/v1.1.6 April 19, 2023 18:54
@esomore esomore changed the base branch from release/v1.1.6 to develop April 19, 2023 19:02
@esomore esomore changed the base branch from develop to release/v1.1.16 April 19, 2023 19:02
@esomore
Copy link
Contributor Author

esomore commented Apr 19, 2023 •
edited

Please retarget your PR to be against release/v1.1.16 - the upcoming release.

@mfahampshire Done

@mfahampshire mfahampshire merged commit 46bf654 into nymtech:release/v1.1.16 Apr 25, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@mfahampshire mfahampshire Awaiting requested review from mfahampshire mfahampshire is a code owner

@aniampio aniampio Awaiting requested review from aniampio

@neacsu neacsu Awaiting requested review from neacsu

@mmsinclair mmsinclair Awaiting requested review from mmsinclair

@fmtabbara fmtabbara Awaiting requested review from fmtabbara

@durch durch Awaiting requested review from durch

@futurechimp futurechimp Awaiting requested review from futurechimp

@jstuczyn jstuczyn Awaiting requested review from jstuczyn

@octol octol Awaiting requested review from octol

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@esomore @mfahampshire