Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sign when announcing service providers to the directory contract #3459

Merged
merged 43 commits into from
Jun 5, 2023
Merged

Sign when announcing service providers to the directory contract #3459

merged 43 commits into from
Jun 5, 2023

Conversation

octol
Copy link
Contributor

@octol octol commented May 26, 2023 •
edited

Description

Closes: #3360

Require signing when announcing service providers to the service provider directory contract.

Checklist:

  • Create signable payload in nym-cli
  • Sign payload in nym-network-requester
  • Contract changes to verify signature

@octol octol marked this pull request as draft May 26, 2023 09:35
@octol octol force-pushed the jon/feat/service-provider-sign branch 2 times, most recently from 2fd3007 to b1f8387 Compare June 1, 2023 11:58
@octol octol marked this pull request as ready for review June 1, 2023 11:58
@octol octol requested review from durch and jstuczyn as code owners June 1, 2023 11:58
octol added 24 commits June 1, 2023 14:07
@octol
create_payload and call from nym-cli
ad02eff
@octol
Remove some commented out code
59d8e1d
@octol
wip
d031993
@octol
Service announce now compiles
18cadbd
@octol
Fix other compilation issues
eaf459c
@octol
Move ServiceDetails into Service
e266304
@octol
Move service_id inside Service type
6bbaf0f
@octol
wip: start sorting out tests
d10730c
@octol
wip: sorting out testing
2d31d3c
@octol
wip: first announce test now works
b979c6c
@octol
wip: more work on announce test
5547c8d
@octol
Move nonce
6f2375a
@octol
Add check for nonce
47c7b4b
@octol
Extract out some helpers to separate files
97b68c1
@octol
reenable state::services tests
568cfde
@octol
wip: start going through the integration tests
636d709
@octol
All integration tests reenabled
eebd213
@octol
Remove some unused stuff
b902c95
@octol
Iterate on integration tests
5e0d24e
@octol
More iteration on test setup
6a73f22
@octol
Rename to test_setup.rs
c6f1474
@octol
Add more tests specific to signing
13852b4
@octol
Tweak
2c064fa
@octol
Another nonce test and reorg
f60fc83
@octol octol force-pushed the jon/feat/service-provider-sign branch from b1f8387 to 54d8c33 Compare June 1, 2023 12:13
@octol octol requested a review from mfahampshire as a code owner June 1, 2023 12:13
@octol octol changed the base branch from develop to release/v1.1.20 June 1, 2023 12:16
jstuczyn
jstuczyn reviewed Jun 2, 2023
View reviewed changes
common/commands/src/validator/mixnet/mod.rs Show resolved Hide resolved
common/commands/src/validator/mixnet/operators/mod.rs Show resolved Hide resolved
common/cosmwasm-smart-contracts/service-provider-directory/Cargo.toml Outdated Show resolved Hide resolved
common/cosmwasm-smart-contracts/service-provider-directory/src/types.rs Outdated Show resolved Hide resolved
contracts/name-service/src/state/names.rs Show resolved Hide resolved
contracts/service-provider-directory/src/contract/execute.rs Show resolved Hide resolved
contracts/service-provider-directory/src/state/nonce.rs Outdated Show resolved Hide resolved
contracts/service-provider-directory/src/state/services.rs Show resolved Hide resolved
contracts/service-provider-directory/src/test_helpers/signing.rs Show resolved Hide resolved
service-providers/network-requester/src/cli/mod.rs Show resolved Hide resolved
@octol octol merged commit 87cb8a6 into release/v1.1.20 Jun 5, 2023
12 of 13 checks passed
@octol octol deleted the jon/feat/service-provider-sign branch June 5, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstuczyn jstuczyn jstuczyn approved these changes

@durch durch Awaiting requested review from durch durch is a code owner

@mfahampshire mfahampshire Awaiting requested review from mfahampshire

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

service-provider-directory: add signature check when announcing
2 participants
@octol @jstuczyn