Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add name to TaskClient #3844

Merged
merged 5 commits into from
Sep 7, 2023
Merged

feat: add name to TaskClient #3844

merged 5 commits into from
Sep 7, 2023

Conversation

jstuczyn
Copy link
Contributor

@jstuczyn jstuczyn commented Sep 5, 2023

Description

Some QoL that came out from working on #3838. I figured I might as well create a separate PR for it.

It should make it easier to debug those nasty dropped tasks. With named tasks such logs are now available (I have increased the logging level locally just for this example; it's not so verbose in the actual code):

 2023-09-05T14:52:02.031Z INFO  nym_task::signal                     > Received SIGINT
 2023-09-05T14:52:02.031Z INFO  nym_task::manager                    > Sending shutdown
 2023-09-05T14:52:02.031Z INFO  nym_task::manager                    > Waiting for tasks to finish... (Press ctrl-c to force)
 2023-09-05T14:52:02.032Z WARN  TaskClient-node_statistics::Controller-child > the shutdown is getting dropped
 2023-09-05T14:52:02.032Z WARN  TaskClient-node_statistics::Controller       > the shutdown is getting dropped
 2023-09-05T14:52:02.032Z WARN  TaskClient-VerlocPacketListener-child        > the shutdown is getting dropped
 2023-09-05T14:52:02.032Z WARN  TaskClient-VerlocPacketListener-child        > the shutdown is getting dropped
 2023-09-05T14:52:02.032Z WARN  TaskClient-node_statistics::Controller-child > the shutdown is getting dropped
 2023-09-05T14:52:02.033Z WARN  TaskClient-Listener                          > the shutdown is getting dropped
 2023-09-05T14:52:02.033Z WARN  TaskClient-DelayForwarder                    > the shutdown is getting dropped
 2023-09-05T14:52:02.181Z WARN  TaskClient-VerlocMeasurement                 > the shutdown is getting dropped
 2023-09-05T14:52:02.181Z WARN  TaskClient-VerlocPacketListener              > the shutdown is getting dropped
 2023-09-05T14:52:02.181Z WARN  TaskClient-VerlocMeasurer                    > the shutdown is getting dropped
 2023-09-05T14:52:02.186Z WARN  TaskClient-VerlocPacketSender-95.179.226.75:1790 > the shutdown is getting dropped
 2023-09-05T14:52:02.187Z WARN  TaskClient-VerlocPacketSender-51.195.255.51:1790 > the shutdown is getting dropped
 2023-09-05T14:52:02.191Z WARN  TaskClient-VerlocPacketSender-77.91.101.170:1790 > the shutdown is getting dropped
 2023-09-05T14:52:02.199Z WARN  TaskClient-VerlocPacketSender-185.215.167.12:1790 > the shutdown is getting dropped
 2023-09-05T14:52:02.201Z WARN  TaskClient-VerlocPacketSender-82.216.163.131:1790 > the shutdown is getting dropped
 2023-09-05T14:52:02.204Z WARN  TaskClient-VerlocPacketSender-85.1.11.146:1790    > the shutdown is getting dropped
 2023-09-05T14:52:02.205Z WARN  TaskClient-VerlocPacketSender-116.203.115.86:1790 > the shutdown is getting dropped
 2023-09-05T14:52:02.206Z WARN  TaskClient-VerlocPacketSender-185.229.90.217:1790 > the shutdown is getting dropped
 2023-09-05T14:52:02.206Z WARN  TaskClient-VerlocPacketSender-94.130.105.180:1790 > the shutdown is getting dropped
 2023-09-05T14:52:02.207Z WARN  TaskClient-VerlocPacketSender-167.235.134.255:1790 > the shutdown is getting dropped
 2023-09-05T14:52:02.207Z WARN  TaskClient-VerlocPacketSender-173.249.36.4:1790    > the shutdown is getting dropped
 2023-09-05T14:52:02.207Z WARN  TaskClient-VerlocPacketSender-161.97.71.166:1790   > the shutdown is getting dropped
 2023-09-05T14:52:02.208Z WARN  TaskClient-VerlocPacketSender-162.55.174.117:1790  > the shutdown is getting dropped
 2023-09-05T14:52:02.208Z WARN  TaskClient-VerlocPacketSender-167.235.242.140:1790 > the shutdown is getting dropped
 2023-09-05T14:52:02.208Z WARN  TaskClient-VerlocPacketSender-23.88.114.204:1790   > the shutdown is getting dropped
 2023-09-05T14:52:02.209Z WARN  TaskClient-VerlocPacketSender-136.243.90.57:1790   > the shutdown is getting dropped
 2023-09-05T14:52:02.219Z WARN  TaskClient-VerlocPacketSender-65.21.6.230:1790     > the shutdown is getting dropped
 2023-09-05T14:52:02.219Z WARN  TaskClient-VerlocPacketSender-65.108.104.113:1790  > the shutdown is getting dropped
 2023-09-05T14:52:02.220Z WARN  TaskClient-VerlocPacketSender-135.181.250.81:1790  > the shutdown is getting dropped
 2023-09-05T14:52:02.220Z WARN  TaskClient-VerlocPacketSender-135.181.114.98:1790  > the shutdown is getting dropped
 2023-09-05T14:52:02.220Z WARN  TaskClient-VerlocPacketSender-65.21.105.117:1790   > the shutdown is getting dropped
 2023-09-05T14:52:02.221Z WARN  TaskClient-VerlocPacketSender-65.109.1.171:1790    > the shutdown is getting dropped
 2023-09-05T14:52:02.221Z WARN  TaskClient-VerlocPacketSender-65.21.247.54:1790    > the shutdown is getting dropped
 2023-09-05T14:52:02.221Z WARN  TaskClient-VerlocPacketSender-65.109.15.194:1790   > the shutdown is getting dropped
 2023-09-05T14:52:02.221Z WARN  TaskClient-VerlocPacketSender-65.108.248.53:1790   > the shutdown is getting dropped
 2023-09-05T14:52:02.221Z WARN  TaskClient-VerlocPacketSender-65.108.52.71:1790    > the shutdown is getting dropped
 2023-09-05T14:52:02.221Z WARN  TaskClient-VerlocPacketSender-65.108.63.143:1790   > the shutdown is getting dropped
 2023-09-05T14:52:02.221Z WARN  TaskClient-VerlocPacketSender-65.108.243.67:1790   > the shutdown is getting dropped
 2023-09-05T14:52:02.221Z WARN  TaskClient-VerlocPacketSender-135.181.139.72:1790  > the shutdown is getting dropped
 2023-09-05T14:52:02.223Z WARN  TaskClient-VerlocPacketSender-88.201.196.152:1790  > the shutdown is getting dropped
 2023-09-05T14:52:02.224Z WARN  TaskClient-VerlocPacketSender-193.43.146.207:1790  > the shutdown is getting dropped
 2023-09-05T14:52:02.225Z WARN  TaskClient-VerlocPacketSender-185.232.171.127:1790 > the shutdown is getting dropped
 2023-09-05T14:52:02.227Z WARN  TaskClient-VerlocPacketSender-185.8.62.115:1790    > the shutdown is getting dropped
 2023-09-05T14:52:02.241Z WARN  TaskClient-VerlocPacketSender-149.102.129.77:1790  > the shutdown is getting dropped
 2023-09-05T14:52:02.243Z WARN  TaskClient-VerlocPacketSender-83.212.80.96:1790    > the shutdown is getting dropped
 2023-09-05T14:52:02.260Z WARN  TaskClient-VerlocPacketSender-45.11.27.209:1790    > the shutdown is getting dropped
 2023-09-05T14:52:02.263Z WARN  TaskClient-VerlocPacketSender-5.161.114.34:1790    > the shutdown is getting dropped
 2023-09-05T14:52:02.264Z WARN  TaskClient-VerlocPacketSender-5.161.114.178:1790   > the shutdown is getting dropped
 2023-09-05T14:52:02.265Z WARN  TaskClient-VerlocPacketSender-172.81.182.18:1790   > the shutdown is getting dropped
 2023-09-05T14:52:02.266Z WARN  TaskClient-VerlocPacketSender-5.161.81.152:1790    > the shutdown is getting dropped
 2023-09-05T14:52:02.267Z WARN  TaskClient-VerlocPacketSender-5.161.105.116:1790   > the shutdown is getting dropped
 2023-09-05T14:52:02.292Z WARN  TaskClient-VerlocPacketSender-192.151.146.250:1790 > the shutdown is getting dropped
 2023-09-05T14:52:02.314Z WARN  TaskClient-VerlocPacketSender-216.238.77.232:1790  > the shutdown is getting dropped
 2023-09-05T14:52:02.326Z WARN  TaskClient-VerlocPacketSender-204.15.76.157:1790   > the shutdown is getting dropped
 2023-09-05T14:52:02.327Z WARN  TaskClient-VerlocPacketSender-149.28.214.159:1790  > the shutdown is getting dropped
 2023-09-05T14:52:02.340Z WARN  TaskClient-VerlocPacketSender-139.59.92.15:1790    > the shutdown is getting dropped
 2023-09-05T14:52:02.392Z WARN  TaskClient-VerlocPacketSender-38.54.4.21:1790      > the shutdown is getting dropped
 2023-09-05T14:52:02.412Z WARN  TaskClient-VerlocPacketSender-139.162.60.229:1790  > the shutdown is getting dropped
 2023-09-05T14:52:02.416Z WARN  TaskClient-VerlocPacketSender-118.238.220.142:1790 > the shutdown is getting dropped

Checklist:

  • added a changelog entry to CHANGELOG.md

@jstuczyn jstuczyn requested a review from octol September 5, 2023 14:55
@jstuczyn jstuczyn added this to the Kitkat milestone Sep 5, 2023
@jstuczyn jstuczyn self-assigned this Sep 5, 2023
octol
octol reviewed Sep 6, 2023
View reviewed changes
common/task/src/manager.rs Outdated Show resolved Hide resolved
@tommyv1987 tommyv1987 merged commit 273f612 into develop Sep 7, 2023
19 checks passed
@tommyv1987 tommyv1987 deleted the feature/named-task-client branch September 7, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@octol octol octol approved these changes

Assignees

@jstuczyn jstuczyn

Labels
None yet
Projects
None yet
Milestone
Kitkat
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jstuczyn @octol @tommyv1987