-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gateway client registry and api routes #3955
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I'll leave any possibly impact on smoosh to @jstuczyn
Oh yeah. the impact on smoosh will be juicy. bunch of merge conflicts expected, especially since I opted to use axum over semi-unmaintained rocket. But that's a future me problem : ) However, to help me out here, mind making the following changes:
|
Complicated things quite a bit, added MAC verification and replay protection for new registrations, I'll probably do some tidying with the structure, possibly add swagger, but I think the functionality is done now... Also moved to axum |
a737296
to
5362e7d
Compare
Rebased off develop |
Description
Adds HTTP API to Gateway, adds
client_registry
field to Gateway struct. HTTP api supports registering new clients and fetching existing ones. Client struct can be considered a stub where we can put useful stuff in the future. I've copied API structure from the mix node API, hopefully it won't complicate smooshing much.Checklist:
CHANGELOG.md