Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sorting for mixnodes and gateways #3985

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Fix sorting for mixnodes and gateways #3985

merged 1 commit into from
Oct 16, 2023

Conversation

fmtabbara
Copy link
Contributor

Description

Fixes sorting mixnodes by

  • stake saturation
  • routing score
  • operator cost
  • profit margin

Fixes sorting gateways by

  • routing score

Closes: #3984

Checklist:

  • added a changelog entry to CHANGELOG.md

@fmtabbara fmtabbara marked this pull request as ready for review October 12, 2023 13:33
@fmtabbara fmtabbara requested a review from doums October 12, 2023 13:34
@tommyv1987 tommyv1987 self-assigned this Oct 16, 2023
@tommyv1987 tommyv1987 added this to the Kinder milestone Oct 16, 2023
tommyv1987
tommyv1987 approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@tommyv1987 tommyv1987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tommyv1987 tommyv1987 merged commit f08521a into develop Oct 16, 2023
5 checks passed
@tommyv1987 tommyv1987 deleted the bug/issue-3984/fix-mixnode-sorting branch October 16, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doums doums doums approved these changes

@tommyv1987 tommyv1987 tommyv1987 approved these changes

Assignees

@tommyv1987 tommyv1987

Labels
None yet
Projects
None yet
Milestone
Kinder
Development

Successfully merging this pull request may close these issues.

Explorer - ordering nodes by Cost does not work correctly
3 participants
@fmtabbara @doums @tommyv1987