Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

suppress error output #4056

Merged
merged 7 commits into from
Oct 26, 2023
Merged

suppress error output #4056

merged 7 commits into from
Oct 26, 2023

Conversation

tommyv1987
Copy link
Contributor

@tommyv1987 tommyv1987 commented Oct 25, 2023 •
edited

  • we can run the api and set the logging level differently on launch
  • same offending characters are spamming the logs
  • write to tmp file if the same offending characters appear

Tommy Verrall and others added 3 commits October 25, 2023 12:54
suppress error output
700cd16 
- we can run the api and set the logging level differently on launch
- same offending characters are spamming the logs
@tommyv1987
- validate entries don't spam the logs
89746e7
@tommyv1987
keep list of ips in memory before deciding what to do..
8139fcf
@tommyv1987 tommyv1987 marked this pull request as ready for review October 25, 2023 15:15
octol
octol reviewed Oct 26, 2023
View reviewed changes
explorer-api/src/geo_ip/location.rs Outdated Show resolved Hide resolved
explorer-api/src/geo_ip/location.rs Outdated Show resolved Hide resolved
octol
octol reviewed Oct 26, 2023
View reviewed changes
explorer-api/src/helpers.rs Outdated Show resolved Hide resolved
@tommyv1987 tommyv1987 merged commit ef1a453 into develop Oct 26, 2023
8 checks passed
@tommyv1987 tommyv1987 deleted the chore/change-output-to-debug branch October 26, 2023 11:40
@tommyv1987 tommyv1987 added this to the Kinder milestone Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstuczyn jstuczyn jstuczyn left review comments

@octol octol octol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Kinder
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tommyv1987 @octol @jstuczyn