[Bugfix] Packet_router gets drop without handling its shutdown #4491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octol
approved these changes
Mar 21, 2024
simonwicky
force-pushed
the
simon/bugfix_shutdown_packetrouter
branch
from
7f206b3
to
124034c
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When
recover_socket_connectionis called aftersplit_and_listen_for_mixnet_message, its task is stopped and dropped. The task'sshutdownis correctly marked as success, but not thePacketRouter'sshutdownowned by that task.This PR mark as success said
shutdown, preventing a premature client's shutdown.