Feature/initial mixnet contract #515

futurechimp · 2021-03-01T10:52:01Z

No description provided.

…fails.

…l copy/paste for now.

…tion

jstuczyn · 2021-03-01T13:36:18Z

Cargo.toml

+[profile.release.package.mixnet-contracts]
+opt-level = 3
+debug = false
+#rpath = false


I guess those are requirements to compile the wasm contracts, but what's the point of leaving commented fields?

clients/validator/examples/README.md

jstuczyn · 2021-03-01T13:46:18Z

clients/validator/examples/README.md

+cd nymd
+git checkout v0.14.1
+go build -o nymd -mod=readonly -tags "netgo,ledger" -ldflags '-X github.com/cosmos/cosmos-sdk/version.Name=nymd -X github.com/cosmos/cosmos-sdk/version.AppName=nymd -X github.com/CosmWasm/wasmd/app.NodeDir=.nymd -X github.com/cosmos/cosmos-sdk/version.Version=0.14.1 -X github.com/cosmos/cosmos-sdk/version.Commit=1920f80d181adbeaedac1eeea1c1c6e1704d3e49 -X github.com/CosmWasm/wasmd/app.Bech32Prefix=nym -X "github.com/cosmos/cosmos-sdk/version.BuildTags=netgo,ledger"' -trimpath ./cmd/wasmd
+mv nymd $GOBIN


If you follow official Go installation guide, $GOBIN is not getting set (and neither it is set in go env GOBIN (unless I missed something)), perhaps this step should be removed or changed to just say "move the binary to somewhere within your $PATH"? I think this might be less confusing for people

I need to write real docs for this, so far this is just in note-to-self form. I expect at the moment that these docs are you and me level, the real docs writing will take place later on the docs site (and these ones will come out).

jstuczyn · 2021-03-01T13:50:23Z

clients/validator/examples/README.md

+Init the blockchain running with: 
+
+```
+./init.sh


For some reason this gave me an error:
./init.sh: line 22: python: command not found
even though I do have python installed

Ah, I see, when I run the set_contract_upload_permissions.py manually it gave the following error:

Traceback (most recent call last): File "set_contract_upload_permissions.py", line 14, in <module> genesis_file = open(genesis_filename, "r") FileNotFoundError: [Errno 2] No such file or directory: '/home/dave/.nymd/config/genesis.json'

I think it should grab user's home directory rather than use yours : )

However, even after "fixing" the .py file, the first error is still present when running init.sh - not sure why.

Yeah, this is still in quite early form, not ready for release.

jstuczyn · 2021-03-01T13:55:09Z

clients/validator/examples/README.md

+```
+cd nym-driver-example
+npm install
+npx nodemon --exec ts-node ./index.ts  --watch . --ext .ts


It crashed when trying to run this:

npx nodemon --exec ts-node ./index.ts --watch . --ext .ts [nodemon] 2.0.7 [nodemon] to restart at any time, enter `rs` [nodemon] watching path(s): *.* [nodemon] watching extensions: ts [nodemon] starting `ts-node ./index.ts` /home/jedrzej/workspace/nym/clients/validator/examples/nym-driver-example/node_modules/ts-node/src/index.ts:513 return new TSError(diagnosticText, diagnosticCodes) ^ TSError: ⨯ Unable to compile TypeScript: index.ts:1:29 - error TS2307: Cannot find module 'nym-validator-client' or its corresponding type declarations. 1 import ValidatorClient from "nym-validator-client"; ~~~~~~~~~~~~~~~~~~~~~~ index.ts:3:25 - error TS2307: Cannot find module '../../dist/types' or its corresponding type declarations. 3 import { MixNode } from "../../dist/types"; ~~~~~~~~~~~~~~~~~~ at createTSError (/home/jedrzej/workspace/nym/clients/validator/examples/nym-driver-example/node_modules/ts-node/src/index.ts:513:12) at reportTSError (/home/jedrzej/workspace/nym/clients/validator/examples/nym-driver-example/node_modules/ts-node/src/index.ts:517:19) at getOutput (/home/jedrzej/workspace/nym/clients/validator/examples/nym-driver-example/node_modules/ts-node/src/index.ts:752:36) at Object.compile (/home/jedrzej/workspace/nym/clients/validator/examples/nym-driver-example/node_modules/ts-node/src/index.ts:968:32) at Module.m._compile (/home/jedrzej/workspace/nym/clients/validator/examples/nym-driver-example/node_modules/ts-node/src/index.ts:1056:42) at Module._extensions..js (node:internal/modules/cjs/loader:1120:10) at Object.require.extensions.<computed> [as .ts] (/home/jedrzej/workspace/nym/clients/validator/examples/nym-driver-example/node_modules/ts-node/src/index.ts:1059:12) at Module.load (node:internal/modules/cjs/loader:971:32) at Function.Module._load (node:internal/modules/cjs/loader:812:14) at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:76:12) [nodemon] app crashed - waiting for file changes before starting...

Interesting. Did you npm install and npm run build first?

I run npm install as per instruction, but didn't do npm run build. I just run it now and it returned an error:

❯ npm run build > nym-driver-example@1.0.0 build > tsc index.ts:1:29 - error TS2307: Cannot find module 'nym-validator-client' or its corresponding type declarations. 1 import ValidatorClient from "nym-validator-client"; ~~~~~~~~~~~~~~~~~~~~~~ index.ts:3:25 - error TS2307: Cannot find module '../../dist/types' or its corresponding type declarations. 3 import { MixNode } from "../../dist/types"; ~~~~~~~~~~~~~~~~~~

Ok let's work this one out in video chat. Grab me when you're around :).

jstuczyn · 2021-03-01T14:43:25Z

clients/validator/src/types.ts

+
+export type MixNodeBond = { // TODO: change name to MixNodeBond
+    owner: string,
+    mix_node: MixNode,    // TODO: camelCase this later once everything else works


so does everything else work now?

jstuczyn · 2021-03-01T14:43:53Z

clients/validator/tests/caches/mixnodes.test.ts

+
+            await cache.refreshMixNodes(contractAddress); // should make multiple paginated requests because there are two pages in the response fixture
+            await cache.refreshMixNodes(contractAddress);
+            // mockClient.verify(netClient => netClient.getMixNodes(contractAddress, perPage, undefined), Times.Exactly(1));


Any reason for leaving those out?

jstuczyn · 2021-03-01T14:44:20Z

clients/validator/src/stargate-helper.ts

+    bech32prefix: "nym",
+};
+
+// const connect = async (


What about this bit?

jstuczyn · 2021-03-01T14:44:54Z

clients/validator/src/net-client.ts

@@ -0,0 +1,102 @@
+import { SigningCosmWasmClient, SigningCosmWasmClientOptions } from '@cosmjs/cosmwasm-stargate';
+import { MixNodeBond } from './types'
+// import { connect as connectHelper } from "./stargate-helper";


jstuczyn · 2021-03-01T14:46:53Z

clients/validator/src/caches/mixnodes.ts

+    /// otherwise returns false.
+    shouldMakeAnotherRequest(response: PagedResponse): boolean {
+        let next = response.start_next_after;
+        let nextExists: boolean = (next != null && next != undefined && next != "");


One thing I've learned after my disgusting adventure through javascript is that you should almost always use the stricter triple equals, i.e. next !== null rather than next != null

…act upload

jstuczyn · 2021-03-09T10:52:29Z

.gitignore

@@ -25,3 +25,4 @@ v6-topology.json
 /explorer/downloads/topology.json
 /explorer/public/downloads/mixmining.json
 /explorer/public/downloads/topology.json
+/clients/validator/examples/nym-driver-example/current-contract.txt


What's this magic text file we're ignoring now? (just curious)

futurechimp added 30 commits February 2, 2021 12:30

Starting on cosmwasm smart contracts

9088513

Mixnet contract now builds

a318a8c

Removing license and notice files, the monorepo already has these.

e0d8a00

Removing generated README content

1367bbb

Simplified development instructions a bit.

4ec1d00

Converted some network monitor files to use SPDX license headers

17a0990

Renamed packaget to mixnet-contracts

535ee72

Depending on the Nym topology crate

ee4c422

Renaming contract package in usage

dd285fa

Renamed "announce" to "register_node" in the defined messages

8833cbf

Fixed package name for mixnet contracts in defined release annotations

ff56b6f

Added the mixnet contracts to the Cargo lock file

b2b9704

Renamed some fields in our contract topology

3b2d54f

Using the stringy mixnode from the validator client.

21369a0

Removing mix nodes count from state, we can infer that

216b150

Saving generated code in comment as it's a useful example for now

8d8002d

Renamed "count" to "get_topology"

7d83a13

Adding the beginnings of a validator client (in Typescript)

24e96b0

Starting to integrate example code. WIP.

5e0a7d1

Ignoring generated accounts

a3432c3

Making a few less mixnodes :)

9ed04f9

Adding shebang to start script

7323356

Cranking up the Nym-related gas limits, as otherwise contract upload …

8db142d

…fails.

Simplest mixnode example is now working

a24d0fc

Removing the external client code, it messed up wasm compilation. Wil…

aaac064

…l copy/paste for now.

Contract now wants to add a MixNode rather than an IP string

d477999

Adding mixnodes via contract now works (!)

49c1918

Simplified mixnode registration example

af8d455

Further mixnode-adding simplification.

22f4fcb

Adding author name

bec274a

futurechimp added 13 commits February 26, 2021 13:27

Docs fix

89e1919

Converting interfaces to types

ffc8bcf

Changing mixNodes() to getMixNodes() on client

8c9aba8

We might as well return the nodes we've just retrieved when we refresh

3c3b0c6

Starting work on unbonding

4e48d81

Fixed a caching bug which was causing multiple result sets to be cached

ad24e80

Using the sender address as the key for removal

adc6096

Importing some result stuff so we can find out what happened on execu…

39a5cc6

…tion

Minor messing around to prove that the sequence fully works

a4d1b93

Displaying a nicer message on mixnode unbond

8602b51

Renamed announce to bond in validator client

e00d2ee

Merge branch 'develop' into feature/initial-mixnet-contract

551619e

Fixed unstable clippy warnings

16bec37

jstuczyn requested changes Mar 1, 2021

View reviewed changes

futurechimp added 10 commits March 1, 2021 17:20

Removing commented fields

d902a82

Comment spacing

db47777

Changed announce to bond in example code

8a75267

Making the test accounts directory configurable

ea19b7a

Rebuilt

817acdc

Loading keys from the local ./accounts directory

90983e9

Ignoring contract lockfile

2b17ed8

Saving out a contract lockfile so things continue working after contr…

104d9f9

…act upload

Splitting the driver example into smaller self-contained examples

97ed08a

Deleting the example that Andrew hates so much

c57da11

jstuczyn reviewed Mar 9, 2021

View reviewed changes

futurechimp added 3 commits March 9, 2021 10:54

Making dependabot happy

4450d38

Stricter equals

1407611

Removing unused import

a5ed7b3

jstuczyn merged commit 4ca40fd into develop Mar 9, 2021

jstuczyn deleted the feature/initial-mixnet-contract branch March 9, 2021 11:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/initial mixnet contract #515

Feature/initial mixnet contract #515

futurechimp commented Mar 1, 2021

jstuczyn Mar 1, 2021

jstuczyn Mar 1, 2021

futurechimp Mar 1, 2021

jstuczyn Mar 1, 2021

jstuczyn Mar 1, 2021

jstuczyn Mar 1, 2021

futurechimp Mar 1, 2021

jstuczyn Mar 1, 2021

futurechimp Mar 1, 2021

jstuczyn Mar 2, 2021

futurechimp Mar 2, 2021

jstuczyn Mar 1, 2021

jstuczyn Mar 1, 2021

jstuczyn Mar 1, 2021

jstuczyn Mar 1, 2021

jstuczyn Mar 1, 2021

jstuczyn Mar 9, 2021

Feature/initial mixnet contract #515

Feature/initial mixnet contract #515

Conversation

futurechimp commented Mar 1, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment