Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

print public key for nym client tools #53

Merged
merged 2 commits into from Jan 14, 2020
Merged

print public key for nym client tools #53

merged 2 commits into from Jan 14, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jan 14, 2020

No description provided.

@jstuczyn
Copy link
Contributor

You should rather put it in https://github.com/nymtech/nym/blob/develop/nym-client/src/commands/websocket.rs#L32 and https://github.com/nymtech/nym/blob/develop/nym-client/src/commands/tcpsocket.rs#L36 then use to_b64_string() on the public_key type.

Also, do keep in mind that the 1:1 mapping of public key to address is temporary

jstuczyn
jstuczyn requested changes Jan 14, 2020
View reviewed changes
Copy link
Contributor

@jstuczyn jstuczyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move the print to locations specified in the comment

@jstuczyn jstuczyn merged commit d69603f into nymtech:develop Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jstuczyn