Feature/add node description api #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…description working
jstuczyn
requested changes
May 17, 2021
mixnode/src/node/node_description.rs
Outdated
| } | ||
|
|
||
| impl NodeDescription { | ||
| pub(crate) fn load_from_file(mut config_path: PathBuf) -> io::Result<NodeDescription> { |
There was a problem hiding this comment.
should this (and save_to_file) be given config_path as arguments? Should it rather be node_description_path? Also, as I've mentioned before, I think it should be part of config itself.
mixnode/src/node/node_description.rs
Outdated
| pub(crate) fn load_from_file(mut config_path: PathBuf) -> io::Result<NodeDescription> { | ||
| config_path.push("descriptor.json"); | ||
| let json = fs::read_to_string(config_path)?; | ||
| ::serde_json::from_str(&json) |
There was a problem hiding this comment.
Any particular reason for the strange mixture of json and toml? I.e. we're saving node configuration in a .toml file but for some reason we save description as a .json?
mfahampshire
approved these changes
May 17, 2021
jstuczyn
reviewed
May 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.