Bugfix/verloc fixes and adjustments #618
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests does the following:
tested_nodes
fields to the verloc result to give indication of how many results are expectedrun_started
andrun_finished
fields to the verloc results to give indication of how old are the resultsThe added timeouts significantly decrease time it takes for the measurements to complete as some misconfigured nodes will keep the connection in limbo until the OS TCP timeout kicks in (and I'm actually not entirely sure if there are some edge cases that might keep it alive indefinitely hence never allowing verloc to finish, so maybe it's a bugfix after all.)