Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/verloc fixes and adjustments #618

Merged
merged 10 commits into from
Jun 2, 2021

Conversation

jstuczyn
Copy link
Contributor

@jstuczyn jstuczyn commented May 26, 2021

This pull requests does the following:

  • Introduces timeout on trying to establish connection to tested nodes
  • Introduces timeout when trying to write packets to tested nodes
  • Saves verloc results in tested chunks rather than everything when it's done (i.e. by default writes in increments of 50)
  • Adds tested_nodes fields to the verloc result to give indication of how many results are expected
  • Adds run_started and run_finished fields to the verloc results to give indication of how old are the results

The added timeouts significantly decrease time it takes for the measurements to complete as some misconfigured nodes will keep the connection in limbo until the OS TCP timeout kicks in (and I'm actually not entirely sure if there are some edge cases that might keep it alive indefinitely hence never allowing verloc to finish, so maybe it's a bugfix after all.)

@jstuczyn jstuczyn added the bug Something isn't working label May 26, 2021
@jstuczyn jstuczyn added this to the 0.10.2 milestone May 26, 2021
@jstuczyn jstuczyn added this to In progress in Core systems via automation May 26, 2021
@jstuczyn jstuczyn added enhancement New feature or request and removed bug Something isn't working labels May 26, 2021
@futurechimp futurechimp merged commit 93e9dc5 into develop Jun 2, 2021
@futurechimp futurechimp deleted the bugfix/verloc-fixes-and-adjustments branch June 2, 2021 11:50
Core systems automation moved this from In progress to Done Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Core systems
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants