Changed rewarding behaviour on not found bonds #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes behaviour on mixnode/gateway rewarding if the target bond does not exist. Prior to this change it would simply return an error. It is now changed to an early terminate with an "Ok" result as well as an attribute indicating that the bond was not found.
The reason for the change is to help with automated rewarding. Right now if we decide to send 100 rewards in a single block, if one of them fails due to bond not being found (which happens relatively frequently - somebody just unbonded their node after the rewarding script started executing), the entire block fails and it's a hassle to recover from it. Now instead, in theory, it should all continue without an issue.