Feature/describe location #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstuczyn
reviewed
Jun 24, 2021
jstuczyn
approved these changes
Jun 25, 2021
Renaming the function to have a clear separation between different parts of the version, especially for future patch upgrade functions. Also switch to a Result return value for these functions, to gather all the ``` eprintln! print_failed_upgrade exit(1) ``` calls in one place. Signed-off-by: Bogdan-Ștefan Neacșu <bogdan@nymtech.net>
Removed location from the init output and added it as input in the describe command. Because this creates a different format of the description file, the patch version number must also be increased. Signed-off-by: Bogdan-Ștefan Neacșu <bogdan@nymtech.net>
Add a positive and a negative unit test for upgrading to 10.0.2. Signed-off-by: Bogdan-Ștefan Neacșu <bogdan@nymtech.net>
This fixes the warning caused by `clippy::field-reassign-with-default` Signed-off-by: Bogdan-Ștefan Neacșu <bogdan@nymtech.net>
- Use concrete location for example - Removed `Location` from displayed information - Replace tuple with a type alias - Commit description to disk once the upgrade is finalized - Other minor changes Signed-off-by: Bogdan-Ștefan Neacșu <bogdan@nymtech.net>
neacsu
force-pushed
the
feature/describe_location
branch
from
1cdc0d0
to
12ddf80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Give a mixnode operator the possibility to
describethe location of its mixnode. Also removed the location from theinitoutput.