Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove mut where possible, parallel cache requests #668

Merged
merged 2 commits into from
Jul 2, 2021
Merged

Remove mut where possible, parallel cache requests #668

merged 2 commits into from
Jul 2, 2021

Conversation

durch
Copy link
Contributor

@durch durch commented Jul 1, 2021

  • Remove mut where applicable
  • join! on cache requests

jstuczyn
jstuczyn approved these changes Jul 2, 2021
View reviewed changes
Copy link
Contributor

@jstuczyn jstuczyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but you've left out one mut to validator_client in clients/webassembly/src/client/mod.rs line 258 (for some reason I couldn't leave my comment directly at it)

@durch
Copy link
Contributor Author

durch commented Jul 2, 2021

Looks good, but you've left out one mut to validator_client in clients/webassembly/src/client/mod.rs line 258 (for some reason I couldn't leave my comment directly at it)

Great catch!

@durch durch merged commit 3aafe54 into develop Jul 2, 2021
@durch durch deleted the no-mut-validator-client branch July 2, 2021 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstuczyn jstuczyn jstuczyn approved these changes

@neacsu neacsu neacsu approved these changes

@futurechimp futurechimp Awaiting requested review from futurechimp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@durch @jstuczyn @neacsu