Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minimize read/write cache contention #676

Merged
merged 4 commits into from
Jul 8, 2021
Merged

Minimize read/write cache contention #676

merged 4 commits into from
Jul 8, 2021

Conversation

durch
Copy link
Contributor

@durch durch commented Jul 5, 2021 •
edited

  • Moves RwLocks into ValidatorCache struct in order to minimize locking, and avoid contention and avoid timeouts
  • Returns full Cache struct as Json in order to provide as_at to the caller as well

@durch durch changed the title Add timeout to cache.write() call Minimize read/write cache contention Jul 5, 2021
@jstuczyn jstuczyn merged commit 3886ec5 into develop Jul 8, 2021
@jstuczyn jstuczyn deleted the cache-write-timeout branch July 8, 2021 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstuczyn jstuczyn jstuczyn approved these changes

@futurechimp futurechimp Awaiting requested review from futurechimp

@neacsu neacsu Awaiting requested review from neacsu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@durch @jstuczyn