Bond and delegation alerts #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstuczyn
reviewed
Jul 22, 2021
| return !location.trim().includes("physical location of your node") | ||
| } | ||
|
|
||
| const validateHost = (host: string): boolean => { |
There was a problem hiding this comment.
This is not an error on your end, but omission in what I've done - could you check for white spaces at beginning (and end) of the host string? I've noticed people were bonding with for example <SPACE-HERE>1.1.1.1 value. Or maybe just trim it for them.
There was a problem hiding this comment.
I've updated this. Hopefully that's what you're after.
jstuczyn
approved these changes
Jul 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display alert on bonding and delegation pages when the user is allocating all of their tokens.