Explorer API - add port check and node description/stats proxy #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes mixed-content responses when using the mix node API from the network explorer. An in-memory cache protects the explorer API from over-querying the http API on the mix node.
…d `/stats` http api resources to allow the network explorer do https requests for the mix node api resource avoid mixed content requests
jstuczyn
reviewed
Aug 10, 2021
| { | ||
| self.inner | ||
| .get(&identity_key) | ||
| .filter(|cache_item| cache_item.valid_until > SystemTime::now()) |
There was a problem hiding this comment.
Just a suggestion, perhaps there should be some way of removing stale entries from the cache? Right now everything will just stay there forever
There was a problem hiding this comment.
Yeah, it is a bit wasteful generally - although I'm hoping the memory requirements for thousands of nodes will still be megabytes. I can add a cleanup background task sometime if it becomes a problem.
jstuczyn
approved these changes
Aug 10, 2021
… and remove custom CORS handler
jstuczyn
approved these changes
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new features to the Explorer API:
mix_port,verloc_port,http_api_port)/descriptionand/statsfrom mix node http API to allow the Network Explorer UI to make requests for these without mixed content errors (http fetches from an app served on https)The default cache TTL is 30 minutes.