Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add stake reward rates and bump version of client #738

Merged
merged 3 commits into from
Aug 16, 2021
Merged

Add stake reward rates and bump version of client #738

merged 3 commits into from
Aug 16, 2021

Conversation

neacsu
Copy link
Contributor

@neacsu neacsu commented Aug 13, 2021

This is needed as a separate PR so that we can publish the 0.17 version before changing the dependency version in the wallet

@neacsu
Tiny PR to add stake reward rates and bump version
3fa4abb 
This is needed so that we can publish the 0.17 version.
@jstuczyn
Copy link
Contributor

jstuczyn commented Aug 13, 2021 •
edited
Loading

But the changes have not yet been made in the contract? - this was referring to the early version of the PR that only modified the typescript code.

@neacsu
Add the changes to contracts as well
84ad696 
On second thought, update the contract together with the client, and
leave the wallet changes for another PR.
@neacsu neacsu changed the title Tiny PR to add stake reward rates and bump version Add stake reward rates and bump version of client Aug 13, 2021
jstuczyn
jstuczyn reviewed Aug 13, 2021
View reviewed changes
Copy link
Contributor

@jstuczyn jstuczyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless you want to do it in a separate PR, the delegation reward rates are actually not being used

common/mixnet-contract/src/types.rs Outdated Show resolved Hide resolved
@neacsu neacsu merged commit bed09bf into develop Aug 16, 2021
@neacsu neacsu deleted the feature/update_validator_client_version branch August 16, 2021 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jstuczyn jstuczyn jstuczyn approved these changes

@durch durch Awaiting requested review from durch durch is a code owner

@futurechimp futurechimp Awaiting requested review from futurechimp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@neacsu @jstuczyn