Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rectify Method is not saved #27

Closed
lklepner opened this issue Apr 8, 2016 · 7 comments
Closed

Rectify Method is not saved #27

lklepner opened this issue Apr 8, 2016 · 7 comments
Labels

Comments

@lklepner
Copy link
Contributor

lklepner commented Apr 8, 2016

I've noticed that the rectify method is not being saved - ff the page is reloaded the rectification approach returns to the default setting and if the map is cropped the default rectification method is used.

This is a problem because some maps yield much better results with non-default rectification types.

In the case of one of the Hudson River Atlas maps (http://maps.nypl.org/warper/maps/14911) the river is significantly compressed on the map to make room for additional inland space (see note overlaid on the river itself). Thin Plate Spline yields much better results in this case than the auto rectification setting... but the improvement will not be retained in the long run since a page refresh or crop operation will return the rectify method to the original setting.

Thin Plate Spline -
screen shot 2016-04-08 at 8 33 28 am

After reloading the page, allowing the rectify method to change back to auto -
google chromescreensnapz026

@mgiraldo
Copy link
Contributor

good catch. i'd say this is a bug and we need to fix that

@mgiraldo
Copy link
Contributor

this is fixed now: http://maps.nypl.org/warper/maps/14911

rectified

saved

@lklepner
Copy link
Contributor Author

Maps are re-rectified when cropped. I tested that route and got the default/wrong result.

@mgiraldo
Copy link
Contributor

I suppose you did not modify the select boxes? only pressed rectify in the rectify tab?

can you provide the steps to reproduce because I tried several times and this is the result I get after refreshing:

On May 12, 2016, at 19:22, Lou Klepner notifications@github.com wrote:

Maps are re-rectified when cropped. I tested that route and got the default/wrong result.


You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub

@mgiraldo
Copy link
Contributor

oh I think I know what you're talking about

I will look into that. a new bug needs to be filled for that

  • mga

On May 12, 2016, at 19:22, Lou Klepner notifications@github.com wrote:

Maps are re-rectified when cropped. I tested that route and got the default/wrong result.


You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub

@mgiraldo
Copy link
Contributor

fixed in #51 👍

@lklepner
Copy link
Contributor Author

confirmed - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants