Klarocca/side menu #144
Merged
Klarocca/side menu #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walsh9
requested changes
Sep 8, 2020
| outOfViewport=this.outOfViewport | ||
| rules=this.rules | ||
| )}} | ||
| {{#if @showMenuButton}} |
There was a problem hiding this comment.
If you put this conditional into the nypr-o-header/left.hbs template instead, you won't need to use two separate components or duplicate this block
| data-test-main-header | ||
| as |header| | ||
| > | ||
| <header.left data-test-header-left as |left|> |
There was a problem hiding this comment.
With the change suggested above this part of the example would become
<header.left @showMenuButton=false as |left|>
There was a problem hiding this comment.
If we make this change, we'd have to set the showMenuButton=true or =false for all the headers
There was a problem hiding this comment.
We can have a default, the same as if we set it in the top level.
walsh9
approved these changes
Sep 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an option to not have the side menu in the header like we discussed