Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDF (asset) .url gives preview instead of the url of the pdf #349

Closed
limesquare-nl opened this issue Jul 5, 2022 · 4 comments
Closed

PDF (asset) .url gives preview instead of the url of the pdf #349

limesquare-nl opened this issue Jul 5, 2022 · 4 comments
Labels

Comments

@limesquare-nl
Copy link

limesquare-nl commented Jul 5, 2022

Describe the bug

In 1.6.46 and 1.6.45 there is a problem with the asset.url for pdf's. It gives the link to a transformation of the pdf (preview first page) instead of the link to the pdf. Downgrade to 1.6.44 fixes the issue.

To reproduce

In a template output asset.url for a pdf

Expected behaviour

Url to download the pdf

Versions

  • Plugin version: 1.6.46 and 1.6.45
  • Craft version: 3.7.46
@khalwat
Copy link
Contributor

khalwat commented Jul 6, 2022

I'm pretty sure I know what this is, will have a fix shortly.

khalwat added a commit that referenced this issue Jul 6, 2022
khalwat added a commit that referenced this issue Jul 6, 2022
@khalwat
Copy link
Contributor

khalwat commented Jul 6, 2022

Addressed in: 9ffbb99 & f257b53

Craft CMS 3:

You can try it now by setting your semver in your composer.json to look like this:

    "nystudio107/craft-imageoptimize": "dev-develop as 1.6.47”,

Then do a composer clear-cache && composer update

Craft CMS 4:

…..

You can try it now by setting your semver in your composer.json to look like this:

    "nystudio107/craft-imageoptimize": "dev-develop-v4 as 4.0.1”,

Then do a composer clear-cache && composer update

@khalwat
Copy link
Contributor

khalwat commented Jul 6, 2022

Let me know if this addresses it for you, and I will cut a release

@limesquare-nl
Copy link
Author

It works again. Thanks for getting it resolved so quickly

@khalwat khalwat closed this as completed Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant