Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make robots.txt template setting a path instead of template textarea #15

Closed
timkelty opened this issue Mar 14, 2018 · 3 comments
Closed

Comments

@timkelty
Copy link

I would much rather see the robots.txt setting be simple a template path, so that we could keep this in source with all our other templates.

The only benefit I see of having it as a db-based setting is so non-developers could edit it, but it seems like that doesn't really happen.

@timkelty timkelty changed the title Make robots.txt template setting a path Make robots.txt template setting a path instead of template textarea Mar 14, 2018
@timkelty
Copy link
Author

timkelty commented Mar 14, 2018

For that matter, I suppose you could just do away withe the Robots feature all together and just dump your example robots.txt template in the templates root dir.

I guess I don't see the benefit of it being part of the plugin (apart from providing an example templates/robots.txt content)

@khalwat
Copy link
Collaborator

khalwat commented Mar 14, 2018

So you can do this already, by altering the settings in the FrontendTemplatesContainer.php -- just set the path to whatever you want it to be on your setups, and it'll read the default template from there.

@timkelty
Copy link
Author

👍 nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants