Fix incorrect event type #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error happening when additional sitemap URLs added in plugin. Looks like this has been happening since this commit:
4ecdc2a#diff-00283e6e3abca12c7a43592c4bb634d8
Error:
TypeError: Argument 1 passed to dynam\tulloch\Tulloch::dynam\tulloch{closure}() must be an instance of nystudio107\seomatic\events\RegisterSitemapUrlsEvent, instance of nystudio107\seomatic\events\RegisterSitemapsEvent given in /home/vagrant/code/tulloch-homes.com/plugins/tulloch/src/Tulloch.php:128
Stack trace:
#0 [internal function]: dynam\tulloch\Tulloch->dynam\tulloch{closure}(Object(nystudio107\seomatic\events\RegisterSitemapsEvent))
#1 /home/vagrant/code/tulloch-homes.com/vendor/yiisoft/yii2/base/Event.php(312): call_user_func(Object(Closure), Object(nystudio107\seomatic\events\RegisterSitemapsEvent))
#2 /home/vagrant/code/tulloch-homes.com/vendor/nystudio107/craft-seomatic/src/models/SitemapIndexTemplate.php(223): yii\base\Event::trigger('nystudio107\seo...', 'registerSitemap...', Object(nystudio107\seomatic\events\RegisterSitemapsEvent))
#3 /home/vagrant/code/tulloch-homes.com/vendor/nystudio107/craft-seomatic/src/models/SitemapIndexTemplate.php(178): nystudio107\seomatic\models\SitemapIndexTemplate->addAdditionalSitemaps(Object(nystudio107\seomatic\models\MetaBundle), 1, Array)
#4 [internal function]: nystudio107\seomatic\models\SitemapIndexTemplate->nystudio107\seomatic\models{closure}(Object(yii\caching\FileCache))
#5 /home/vagrant/code/tulloch-homes.com/vendor/yiisoft/yii2/caching/Cache.php(597): call_user_func(Object(Closure), Object(yii\caching\FileCache))
#6 /home/vagrant/code/tulloch-homes.com/vendor/nystudio107/craft-seomatic/src/models/SitemapIndexTemplate.php(140): yii\caching\Cache->getOrSet('seomatic_sitema...', Object(Closure), 30, Object(yii\caching\TagDependency))
#7 /home/vagrant/code/tulloch-homes.com/vendor/nystudio107/craft-seomatic/src/services/Sitemaps.php(166): nystudio107\seomatic\models\SitemapIndexTemplate->render(Array)
#8 /home/vagrant/code/tulloch-homes.com/vendor/nystudio107/craft-seomatic/src/controllers/SitemapController.php(55): nystudio107\seomatic\services\Sitemaps->renderTemplate('SeomaticSitemap...', Array)
#9 [internal function]: nystudio107\seomatic\controllers\SitemapController->actionSitemapIndex(1, NULL)
#10 /home/vagrant/code/tulloch-homes.com/vendor/yiisoft/yii2/base/InlineAction.php(57): call_user_func_array(Array, Array)
#11 /home/vagrant/code/tulloch-homes.com/vendor/yiisoft/yii2/base/Controller.php(157): yii\base\InlineAction->runWithParams(Array)
#12 /home/vagrant/code/tulloch-homes.com/vendor/craftcms/cms/src/web/Controller.php(110): yii\base\Controller->runAction('sitemap-index', Array)
#13 /home/vagrant/code/tulloch-homes.com/vendor/yiisoft/yii2/base/Module.php(528): craft\web\Controller->runAction('sitemap-index', Array)
#14 /home/vagrant/code/tulloch-homes.com/vendor/craftcms/cms/src/web/Application.php(297): yii\base\Module->runAction('seomatic/sitema...', Array)
#15 /home/vagrant/code/tulloch-homes.com/vendor/yiisoft/yii2/web/Application.php(103): craft\web\Application->runAction('seomatic/sitema...', Array)
#16 /home/vagrant/code/tulloch-homes.com/vendor/craftcms/cms/src/web/Application.php(286): yii\web\Application->handleRequest(Object(craft\web\Request))
#17 /home/vagrant/code/tulloch-homes.com/vendor/yiisoft/yii2/base/Application.php(386): craft\web\Application->handleRequest(Object(craft\web\Request))
#18 /home/vagrant/code/tulloch-homes.com/web/index.php(21): yii\base\Application->run()
#19 {main}