Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEO Meta is being cached globally instead of for each site #17

Closed
riasvdv opened this issue Mar 15, 2018 · 2 comments
Closed

SEO Meta is being cached globally instead of for each site #17

riasvdv opened this issue Mar 15, 2018 · 2 comments

Comments

@riasvdv
Copy link

riasvdv commented Mar 15, 2018

When you have a multi-site install, the SEO meta gets cached without accounting for the site.

So when I have a site with a sitename of "Site 1" and view a page on it, the site name stays the same in the title even when viewing a page on site 2.

@khalwat
Copy link
Collaborator

khalwat commented Mar 15, 2018

Hrm. Are we sure it's caching that's the problem? The meta container case does seem to account for the $siteId:

https://github.com/nystudio107/craft-seomatic/blob/v3/src/services/MetaContainers.php#L135

$cache->getOrSet(
                $this::CACHE_KEY.$uri.$siteId,
                function () use ($uri, $siteId) {```

@khalwat
Copy link
Collaborator

khalwat commented Mar 15, 2018

@khalwat khalwat closed this as completed Mar 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants