Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand useTracking API to accept contextual data #168

Merged
merged 18 commits into from
Nov 11, 2020
Merged

Expand useTracking API to accept contextual data #168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
9c11b0d
Copy additional functionality to hook
bgergen Oct 26, 2020
6303cd4
Call hook from decorator
bgergen Oct 27, 2020
c707421
Fix props issue & tests
bgergen Oct 28, 2020
c621ed8
Remove top-level hook warning
bgergen Oct 28, 2020
67d18d2
Unskip & update hook tests
bgergen Oct 29, 2020
e1ec87d
Remove lint warnings
bgergen Oct 29, 2020
e9902af
Remove extraneous loc
bgergen Oct 30, 2020
c032079
Move core functionality into separate hook
bgergen Oct 31, 2020
584188a
Clean up tests
bgergen Oct 31, 2020
6d93d49
Move ReactTrackingContext into separate file, update useTracking tests
bgergen Nov 2, 2020
8b708cc
Update src/__tests__/hooks.test.js
bgergen Nov 2, 2020
ba02f10
Update tests
bgergen Nov 2, 2020
f4b9c19
More test updates
bgergen Nov 2, 2020
266a3bd
Fix lint error
bgergen Nov 2, 2020
ef0a911
Store data & options in refs
bgergen Nov 5, 2020
765276c
Update hooks test to call dispatch mock
bgergen Nov 6, 2020
5d04a23
Update tests, fix memoization bug
bgergen Nov 6, 2020
7547855
tweak + small new test (#170)
tizmagik Nov 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/ReactTrackingContext.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
import React from 'react';

export default React.createContext({});
4 changes: 1 addition & 3 deletions src/__tests__/e2e.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -711,9 +711,7 @@ describe('e2e', () => {
});

it('root context items are accessible to children', () => {
const {
ReactTrackingContext,
} = require('../withTrackingComponentDecorator'); // eslint-disable-line global-require
const ReactTrackingContext = require('../ReactTrackingContext').default; // eslint-disable-line global-require

const App = track()(() => {
return <Child />;
Expand Down