Update Metrics/Write Preds Testing #697
Conversation
pruksmhc
requested review from
iftenney,
sleepinyourhat and
W4ngatang
as code owners
|
Hello @pruksmhc! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
You can repair most issues by installing black and running: Comment last updated at 2019-06-19 01:15:43 UTC |
… into check_update_metrics
pruksmhc
changed the title
|
Ready for another review @sleepinyourhat |
|
Last bit of cleanup, plus make sure tests pass. |
…update_metrics
environment.yml
Outdated
| @@ -16,6 +16,7 @@ dependencies: | |||
| - tensorboard | |||
| - tensorboardX==1.2 | |||
| - sendgrid==5.4.1 | |||
| - pyhocon==0.3.35 | |||
There was a problem hiding this comment.
Not sure why this is appearing in this diff - this is the same as master.
tests/test_write_preds.py
Outdated
| self.wic.val_data = [ | ||
| Instance( | ||
| { | ||
| "sent1_str": MetadataField("Room and board yo."), |
There was a problem hiding this comment.
is this a real example??
There was a problem hiding this comment.
Oh nope :P , deleting the yo
…update_metrics
… into check_update_metrics
* adding initial tests * adding initial tests * black formatting * adding more than 1 val_preds, changing sts-b example * reduced to 2 examples for update_metrics * batch siz eof one test, cleaning up tests * changing directory for .CircleCI builds * removed extra changes * fixing WiC.jsonl name in write_preds_test * black * nit picking * black styling
Tests to determine that updating metrics and writing predictions works as expected.